chore: remove unused test files and cicd workflows (#4732)

Author: j-luong

.circleci/config.yml

@@ -565,7 +565,7 @@ jobs:
             GOOS: << parameters.go_os >>
             GOARCH: << parameters.go_arch >>
             CLI_V1_LOCATION: ../binary-releases
-          command: make build build-test install prefix=. -e
+          command: make build install prefix=. -e
       - save_cache:
           key: go-build-{{ arch }}-{{ checksum "cliv2/go.sum" }}
           paths: [/home/circleci/go/pkg/mod]
@@ -724,70 +724,6 @@ jobs:
       - store_artifacts:
           path: ./cliv2/bin
 
-  v2-test-linux-amd64:
-    executor: docker-node
-    working_directory: /home/circleci/snyk
-    steps:
-      - checkout
-      - attach_workspace:
-          at: .
-      - run:
-          name: Run integration tests
-          working_directory: ./cliv2
-          environment:
-            TEST_SNYK_EXECUTABLE_PATH: ./bin/snyk-linux
-          command: |
-            export SNYK_TOKEN="${SNYK_API_KEY}"
-            ./bin/snyk_tests_linux_amd64
-
-  v2-test-linux-arm64:
-    executor: arm64
-    working_directory: /home/circleci/snyk
-    steps:
-      - checkout
-      - attach_workspace:
-          at: .
-      - run:
-          name: Run integration tests
-          working_directory: ./cliv2
-          environment:
-            TEST_SNYK_EXECUTABLE_PATH: ./bin/snyk-linux-arm64
-          command: |
-            export SNYK_TOKEN="${SNYK_API_KEY}"
-            ./bin/snyk_tests_linux_arm64
-
-  v2-test-darwin-amd64:
-    executor: macos
-    working_directory: /Users/distiller/snyk
-    steps:
-      - checkout
-      - attach_workspace:
-          at: .
-      - run:
-          name: Run integration tests
-          working_directory: ./cliv2
-          environment:
-            TEST_SNYK_EXECUTABLE_PATH: ./bin/snyk-macos
-          command: |
-            export SNYK_TOKEN="${SNYK_API_KEY}"
-            ./bin/snyk_tests_darwin_amd64
-
-  v2-test-windows-amd64:
-    executor: win/default
-    working_directory: C:\Users\circleci\snyk
-    steps:
-      - checkout
-      - attach_workspace:
-          at: .
-      - run:
-          name: Run integration tests
-          working_directory: ./cliv2
-          environment:
-            TEST_SNYK_EXECUTABLE_PATH: ./bin/snyk-win.exe
-          command: |
-            $env:SNYK_TOKEN = $env:SNYK_API_KEY
-            ./bin/snyk_tests_windows_amd64.exe
-
   v2-sign-darwin-amd64:
     executor: macos
     working_directory: /Users/distiller/snyk
@@ -1058,34 +994,6 @@ workflows:
           go_os: alpine
           go_arch: amd64
           c_compiler: /usr/bin/musl-gcc
-      - v2-test-linux-amd64:
-          filters:
-            branches:
-              ignore: master
-          name: v2 / Integration Tests (linux/amd64)
-          requires:
-            - v2 / Rename linux/amd64 artifact
-      - v2-test-linux-arm64:
-          filters:
-            branches:
-              ignore: master
-          name: v2 / Integration Tests (linux/arm64)
-          requires:
-            - v2 / Rename linux/arm64 artifact
-      - v2-test-darwin-amd64:
-          filters:
-            branches:
-              ignore: master
-          name: v2 / Integration Tests (darwin/amd64)
-          requires:
-            - v2 / Rename macos/amd64 artifact
-      - v2-test-windows-amd64:
-          filters:
-            branches:
-              ignore: master
-          name: v2 / Integration Tests (windows/amd64)
-          requires:
-            - v2 / Rename windows/amd64 artifact
       # Tests for backwards compatibility with CLIv1
       - test-alpine:
           filters:

cliv2/Makefile

@@ -164,24 +164,9 @@ $(BUILD_DIR)/$(V2_EXECUTABLE_NAME).$(HASH_STRING):
 	@echo "$(LOG_PREFIX) Generating checksum ( $(BUILD_DIR)/$(V2_EXECUTABLE_NAME).$(HASH_STRING) )"
 	@cd $(BUILD_DIR) && shasum -a $(HASH_ALGORITHM) --binary $(V2_EXECUTABLE_NAME) > $(V2_EXECUTABLE_NAME).$(HASH_STRING)
 
-$(BUILD_DIR)/$(TEST_EXECUTABLE_NAME):
-	@echo "$(LOG_PREFIX) Building test executable ( $(BUILD_DIR)/$(TEST_EXECUTABLE_NAME) )"
-	@GOOS=$(_GO_OS) GOARCH=$(GOARCH) $(GOCMD) test -c -o $(BUILD_DIR)/$(TEST_EXECUTABLE_NAME) main_integration_test.go
-
 .PHONY: build
 build: configure $(BUILD_DIR)/$(V2_EXECUTABLE_NAME) $(BUILD_DIR)/$(V2_EXECUTABLE_NAME).$(HASH_STRING)
 
-.PHONY: build-test
-build-test: build-blackboxtest
-
-.PHONY: build-blackboxtest
-build-blackboxtest: build $(BUILD_DIR)/$(TEST_EXECUTABLE_NAME)
-
-.PHONY: blackboxtest
-blackboxtest: build-blackboxtest
-	@echo "$(LOG_PREFIX) Running $@"
-	TEST_SNYK_EXECUTABLE_PATH=$(TEST_SNYK_EXECUTABLE_PATH) $(BUILD_DIR)/$(TEST_EXECUTABLE_NAME) -test.v
-
 $(WORKING_DIR)/internal/httpauth/generated/httpauth_generated_mock.go:
 	@$(GOCMD) generate ./internal/httpauth/
 
@@ -202,7 +187,7 @@ whiteboxtest:
 	@$(GOCMD) test -cover ./...
 
 .PHONY: test
-test: whiteboxtest blackboxtest
+test: whiteboxtest
 
 .PHONY: lint
 lint:
@@ -252,7 +237,7 @@ clean-ts-cli:
 # build the full CLI (Typescript+Golang)
 .PHONY: build-full
 build-full: | build-ts-cli
-	@$(MAKE) build build-test CLI_V1_VERSION_TAG=$(CLI_V1_VERSION_TAG) CLI_V1_LOCATION="$(CLI_V1_LOCATION)"
+	@$(MAKE) build CLI_V1_VERSION_TAG=$(CLI_V1_VERSION_TAG) CLI_V1_LOCATION="$(CLI_V1_LOCATION)"
 
 # clean the full CLI (Typescript+Golang)
 .PHONY: clean-full
@@ -279,7 +264,6 @@ install:
 	@rm -f $(DESTDIR)$(bindir)/$(V2_EXECUTABLE_NAME)
 	@cp $(BUILD_DIR)/$(V2_EXECUTABLE_NAME) $(DESTDIR)$(bindir)
 	@cp $(BUILD_DIR)/$(V2_EXECUTABLE_NAME).$(HASH_STRING) $(DESTDIR)$(bindir)
-	@cp $(BUILD_DIR)/$(TEST_EXECUTABLE_NAME) $(DESTDIR)$(bindir)
 
 .PHONY: help
 help:
@@ -288,7 +272,6 @@ help:
 	@echo "$(LOG_PREFIX) format"
 	@echo "$(LOG_PREFIX) build"
 	@echo "$(LOG_PREFIX) sign"
-	@echo "$(LOG_PREFIX) build-test"
 	@echo "$(LOG_PREFIX) test"
 	@echo "$(LOG_PREFIX) test-signature"
 	@echo "$(LOG_PREFIX) install"