Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presenter view should show clicks #2088

Closed
c-harding opened this issue Feb 25, 2025 · 3 comments · Fixed by #2102
Closed

Presenter view should show clicks #2088

c-harding opened this issue Feb 25, 2025 · 3 comments · Fixed by #2102
Assignees

Comments

@c-harding
Copy link

c-harding commented Feb 25, 2025

Is your feature request related to a problem? Please describe.

I want to see the next text that will appear in the “Next” preview in presenter mode.

In this view, I want to see the line “This shows up when you click the slide:” in the “Next” preview:

https://sli.dev/demo/starter/presenter/9

Describe the solution you'd like

The “next” view should show the state after the next click, including the next bullet point.

Describe alternatives you've considered

Custom CSS that makes v-click content visible inside the “Next” preview, but this would be more fiddly. And this would show all, rather than just the next, v-click.

Other things to consider

Ideally the animations would be disabled (reduced to 0ms), so I can see the next state of magic move.

@Arsenicro
Copy link

I believe this is a bug. It was working like this on 51.1.0

@carlobellettini
Copy link

carlobellettini commented Mar 4, 2025

It seems to me that the problem is in #2073 . (The fix was for PDF exporting, but broke preview)

Reverting it fix the preview in presentation mode

in file useClicks.ts
line 168

+   ref(Math.max(toValue(currentInit), clicksStart)),   // original line ... preview working
-   computed(() => Math.max(toValue(currentInit), clicksStart)),  // broken line ... preview not working (but perhaps PDF exporting fix)

@c-harding
Copy link
Author

cc @kermanx @antfu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants