Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

design discussion: objects vs estimators #32

Closed
fkiraly opened this issue Jul 28, 2022 · 1 comment
Closed

design discussion: objects vs estimators #32

fkiraly opened this issue Jul 28, 2022 · 1 comment

Comments

@fkiraly
Copy link
Contributor

fkiraly commented Jul 28, 2022

Should estimators be in scope of the baseobject package?
If yes, what is the scope precisely?

I have been working on separating objects from estimators in sktime, see here: sktime/sktime#3122
@RNKuhns RNKuhns mentioned this issue Nov 22, 2022
Merged
@RNKuhns RNKuhns added this to the Release 0.4.0 milestone Dec 27, 2022
@RNKuhns
Copy link
Contributor

RNKuhns commented Jan 8, 2023

We've included a BaseEstimator functionality with basic interface in skbase. Closing this.

@RNKuhns RNKuhns closed this as completed Jan 8, 2023
@RNKuhns RNKuhns removed this from the Release 0.4.0 milestone Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fkiraly @RNKuhns