Skip to content

Commit 5548662

Browse files
committed
Mod/DetectorHist: do not use TH*I as they cannot be normalized (all bins 0)
(cherry picked from commit 8d5f65f)
1 parent 455b6c2 commit 5548662

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

src/modules/DetectorHistogrammer/DetectorHistogrammerModule.cpp

+9-9
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ void DetectorHistogrammerModule::init() {
3838
LOG(TRACE) << "Creating histograms";
3939
std::string hit_map_name = "hit_map";
4040
std::string hit_map_title = "Hitmap for " + detector_->getName() + ";x (pixels);y (pixels)";
41-
hit_map = new TH2I(hit_map_name.c_str(),
41+
hit_map = new TH2D(hit_map_name.c_str(),
4242
hit_map_title.c_str(),
4343
model->getNPixels().x(),
4444
-0.5,
@@ -50,7 +50,7 @@ void DetectorHistogrammerModule::init() {
5050
// Create histogram of cluster map
5151
std::string cluster_map_name = "cluster_map";
5252
std::string cluster_map_title = "Cluster map for " + detector_->getName() + ";x (pixels);y (pixels)";
53-
cluster_map = new TH2I(cluster_map_name.c_str(),
53+
cluster_map = new TH2D(cluster_map_name.c_str(),
5454
cluster_map_title.c_str(),
5555
model->getNPixels().x(),
5656
-0.5,
@@ -62,23 +62,23 @@ void DetectorHistogrammerModule::init() {
6262
// Create cluster size plots
6363
std::string cluster_size_name = "cluster_size";
6464
std::string cluster_size_title = "Cluster size for " + detector_->getName() + ";cluster size [px];clusters";
65-
cluster_size = new TH1I(cluster_size_name.c_str(),
65+
cluster_size = new TH1D(cluster_size_name.c_str(),
6666
cluster_size_title.c_str(),
67-
model->getNPixels().x() * model->getNPixels().y(),
67+
model->getNPixels().x() * model->getNPixels().y() / 10,
6868
0.5,
69-
model->getNPixels().x() * model->getNPixels().y() + 0.5);
69+
model->getNPixels().x() * model->getNPixels().y() / 10 + 0.5);
7070

7171
std::string cluster_size_x_name = "cluster_size_x";
7272
std::string cluster_size_x_title = "Cluster size X for " + detector_->getName() + ";cluster size x [px];clusters";
73-
cluster_size_x = new TH1I(cluster_size_x_name.c_str(),
73+
cluster_size_x = new TH1D(cluster_size_x_name.c_str(),
7474
cluster_size_x_title.c_str(),
7575
model->getNPixels().x(),
7676
0.5,
7777
model->getNPixels().x() + 0.5);
7878

7979
std::string cluster_size_y_name = "cluster_size_y";
8080
std::string cluster_size_y_title = "Cluster size Y for " + detector_->getName() + ";cluster size y [px];clusters";
81-
cluster_size_y = new TH1I(cluster_size_y_name.c_str(),
81+
cluster_size_y = new TH1D(cluster_size_y_name.c_str(),
8282
cluster_size_y_title.c_str(),
8383
model->getNPixels().y(),
8484
0.5,
@@ -87,7 +87,7 @@ void DetectorHistogrammerModule::init() {
8787
// Create event size plot
8888
std::string event_size_name = "event_size";
8989
std::string event_size_title = "Event size for " + detector_->getName() + ";event size [px];events";
90-
event_size = new TH1I(event_size_name.c_str(),
90+
event_size = new TH1D(event_size_name.c_str(),
9191
event_size_title.c_str(),
9292
model->getNPixels().x() * model->getNPixels().y(),
9393
0.5,
@@ -96,7 +96,7 @@ void DetectorHistogrammerModule::init() {
9696
// Create number of clusters plot
9797
std::string n_cluster_name = "n_cluster";
9898
std::string n_cluster_title = "Number of clusters for " + detector_->getName() + ";clusters;events";
99-
n_cluster = new TH1I(n_cluster_name.c_str(),
99+
n_cluster = new TH1D(n_cluster_name.c_str(),
100100
n_cluster_title.c_str(),
101101
model->getNPixels().x() * model->getNPixels().y(),
102102
0.5,

src/modules/DetectorHistogrammer/DetectorHistogrammerModule.hpp

+7-7
Original file line numberDiff line numberDiff line change
@@ -84,13 +84,13 @@ namespace allpix {
8484
std::vector<Cluster*> clusters_;
8585

8686
// Histograms to output
87-
TH2I* hit_map;
88-
TH2I* cluster_map;
89-
TH1I* event_size;
90-
TH1I* cluster_size;
91-
TH1I* cluster_size_x;
92-
TH1I* cluster_size_y;
93-
TH1I* n_cluster;
87+
TH2D* hit_map;
88+
TH2D* cluster_map;
89+
TH1D* event_size;
90+
TH1D* cluster_size;
91+
TH1D* cluster_size_x;
92+
TH1D* cluster_size_y;
93+
TH1D* n_cluster;
9494
TH1D* cluster_charge;
9595
};
9696
} // namespace allpix

0 commit comments

Comments
 (0)