Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on github.com/golang/glog #2113

Closed
jdolitsky opened this issue Jul 29, 2022 · 2 comments
Closed

Remove dependency on github.com/golang/glog #2113

jdolitsky opened this issue Jul 29, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@jdolitsky
Copy link
Contributor

Please see sigstore/policy-controller#112 for more context.

TLDR - without this being removed, policy-controller will crash on startup due to conflicts with the klog dependency.

This appears to be brought in via github.com/google/certificate-transparency-go. After looking there, it led to a rabbit hole of other dependencies which also rely on glog.

I've opened up the following PRs which may or may not be all of the locations:

An alternative could be for the sigstore org to maintain a fork of glog, just for replace purposes. The required changeset would be this.

@haydentherapper
Copy link
Contributor

For some context, I tried to work around this issue awhile ago by copying in files from certificate-transparency-go (https://github.com/sigstore/cosign/blob/f2c360eb97e52fa7766ecde370f1a48b910d7404/cmd/cosign/cli/fulcio/fulcioverifier/ctutil/ctutil.go) to avoid pulling in glog.

@haydentherapper
Copy link
Contributor

Seems to be resolved, I don't see a dependency on glog anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants