Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop needlessly penalizing peers in SingleBlockLookup post-deneb #5095

Closed
ethDreamer opened this issue Jan 19, 2024 · 2 comments
Closed

Stop needlessly penalizing peers in SingleBlockLookup post-deneb #5095

ethDreamer opened this issue Jan 19, 2024 · 2 comments
Assignees
Labels
bug Something isn't working deneb

Comments

@ethDreamer
Copy link
Member

Description

While working on #5082 I noticed that lighthouse will penalize peers for no reason after deneb when doing single lookups for blocks/blobs. It usually seems to attempt to download blobs twice & it penalizes the peer even though it provided the blobs the first time.

Jan 19 09:23:34.063 DEBG Sending BlocksByRoot Request            lookup_type: Parent, peer: 16Uiu2HAm43rREqBxRgieBtumWtqXwctsQtn8BYtssNF5ZhjkvmMS, block_roots: [0x8d32540021cb949b16d685f439495d2396d78c26324d17288213e648451b51e6], method: BlocksByRoot, service: sync
Jan 19 09:23:34.063 DEBG Sending BlobsByRoot Request             lookup_type: Parent, peer: 16Uiu2HAm43rREqBxRgieBtumWtqXwctsQtn8BYtssNF5ZhjkvmMS, blob_indices: [0, 1, 2, 3, 4, 5], block_root: 0x8d32540021cb949b16d685f439495d2396d78c26324d17288213e648451b51e6, method: BlobsByRoot, service: sync
Jan 19 09:23:34.063 DEBG Sync reporting peer                     action: Mid Tolerance Error, peer_id: 16Uiu2HAm43rREqBxRgieBtumWtqXwctsQtn8BYtssNF5ZhjkvmMS, service: sync
Jan 19 09:23:34.064 DEBG Sending BlobsByRoot Request             lookup_type: Parent, peer: 16Uiu2HAm43rREqBxRgieBtumWtqXwctsQtn8BYtssNF5ZhjkvmMS, blob_indices: [0, 1, 2, 3, 4, 5], block_root: 0x8d32540021cb949b16d685f439495d2396d78c26324d17288213e648451b51e6, method: BlobsByRoot, service: sync
Jan 19 09:23:34.064 DEBG Peer score adjusted                     score: inf, peer_id: 16Uiu2HAm43rREqBxRgieBtumWtqXwctsQtn8BYtssNF5ZhjkvmMS, msg: single_blob_failure, service: libp2p
@ethDreamer ethDreamer added bug Something isn't working deneb labels Jan 19, 2024
@ethDreamer ethDreamer self-assigned this Jan 19, 2024
@ethDreamer
Copy link
Member Author

Spent all day debugging this and wrapping my head around the sync code but I believe I've figured out what's going on.. testing now.

@ethDreamer
Copy link
Member Author

this has been fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deneb
Projects
None yet
Development

No branches or pull requests

1 participant