Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV.vim plugin and LargeFile plugin missing, why? #239

Closed
Henri-Lo opened this issue Oct 2, 2017 · 11 comments
Closed

CSV.vim plugin and LargeFile plugin missing, why? #239

Henri-Lo opened this issue Oct 2, 2017 · 11 comments

Comments

@Henri-Lo
Copy link

Henri-Lo commented Oct 2, 2017

I would like to understand why this bundle does not contain CSV.vim plugin and LargeFile plugin.

Is there something to edit CSV files or disable extensions when editing large files?

@sheerun
Copy link
Owner

sheerun commented Oct 3, 2017

I think we had csv.vim but it caused performance issues when editign csv, and generally didn't to much good. As for LargeFile, nobody suggested it yet.

@Henri-Lo
Copy link
Author

Henri-Lo commented Oct 4, 2017

With LargeFile, you won't encounter performance issues with resource-intensive extensions such as CSV.vim. CSV.vim is brilliant but you need to know how to use it, like not using intensive commands such as ArrangeColumn with large files.

@sheerun
Copy link
Owner

sheerun commented Nov 19, 2017

I tried to add chrisbra/csv.vim but it makes loading big csv files considerably slower (even with LargeFile)

Also, I tries LargeFile plugin for 800mb csv file, but it doesn't make any difference.

@chrisbra
Copy link

chrisbra commented Dec 1, 2017

author here. That solely depends on your csv file and the feature (e.g. auto-arranging) you use for it. But in general, it has to parse the csv file to setup the syntax rules, so depending on your data (and attributes) this is kind to be expected. But this should only affect csv files and no other ones.

@sheerun
Copy link
Owner

sheerun commented Dec 30, 2017

Sorry, I can't include in vim-polyglot that makes file loading considerably slower by default. Ideally you'd (@chrisbra) modify csv syntax plugin so it checks whether file has more than few megabytes and prevent parsing in such case. Then I'd have no problems including it.

CSV is an unfortunate exception from other languages as their files tend to be huge, you don't store tenths megabytes of data in .py or .rb file for example. That's why we need this "feature".

@sheerun sheerun closed this as completed Dec 30, 2017
@chrisbra
Copy link

chrisbra commented Jan 3, 2018

I forgot to document how to make the plugin faster, done now. Setting at least g:csv_end to e..g 100 will considerably improve the loading performance of a file.
Also if you have enabled the LargeFile plugin, it will disable the csv plugin for huge files.

@sheerun
Copy link
Owner

sheerun commented Jan 3, 2018

OK, let me check

@whitelynx
Copy link

@sheerun just curious if this one fell through the cracks 😉

@sheerun
Copy link
Owner

sheerun commented Mar 10, 2019

I tried it with:

if !exists('g:csv_start')
  let g:csv_start = 1
endif
if !exists('g:csv_end')
  let g:csv_end = 10
endif

and largefile plugin, but loading of large csv files is still slow, sorry

@sheerun sheerun closed this as completed Mar 10, 2019
@sheerun
Copy link
Owner

sheerun commented Mar 10, 2019

Hmm on second thought it's something different than these two as without them loading is slow as well...

@sheerun sheerun reopened this Mar 10, 2019
@sheerun
Copy link
Owner

sheerun commented Mar 10, 2019

Okay, I've checked once more and it doesn't slow down anything, I've merged csv plugin :) thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants