Skip to content

Commit 547d843

Browse files
committed
Remove dead code - serialize_struct_as_map always called when cattrs.has_flatten()==true
1 parent 005cb84 commit 547d843

File tree

1 file changed

+1
-19
lines changed

1 file changed

+1
-19
lines changed

serde_derive/src/ser.rs

+1-19
Original file line numberDiff line numberDiff line change
@@ -376,26 +376,8 @@ fn serialize_struct_as_map(
376376

377377
let let_mut = mut_if(serialized_fields.peek().is_some() || tag_field_exists);
378378

379-
let len = if cattrs.has_flatten() {
380-
quote!(_serde::__private::None)
381-
} else {
382-
let len = serialized_fields
383-
.map(|field| match field.attrs.skip_serializing_if() {
384-
None => quote!(1),
385-
Some(path) => {
386-
let field_expr = get_member(params, field, &field.member);
387-
quote!(if #path(#field_expr) { 0 } else { 1 })
388-
}
389-
})
390-
.fold(
391-
quote!(#tag_field_exists as usize),
392-
|sum, expr| quote!(#sum + #expr),
393-
);
394-
quote!(_serde::__private::Some(#len))
395-
};
396-
397379
quote_block! {
398-
let #let_mut __serde_state = _serde::Serializer::serialize_map(__serializer, #len)?;
380+
let #let_mut __serde_state = _serde::Serializer::serialize_map(__serializer, _serde::__private::None)?;
399381
#tag_field
400382
#(#serialize_fields)*
401383
_serde::ser::SerializeMap::end(__serde_state)

0 commit comments

Comments
 (0)