Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update our upload-artifact github action version #2370

Closed
amontanez24 opened this issue Feb 14, 2025 · 0 comments · Fixed by #2371
Closed

Update our upload-artifact github action version #2370

amontanez24 opened this issue Feb 14, 2025 · 0 comments · Fixed by #2371
Assignees
@amontanez24
Labels
maintenance Tasks related to infrastructure & dependencies
Milestone
1.18.0

Comments

@amontanez24
Copy link
Contributor

Problem Description

In our dtypes_benchmark github workflow, we use a Github action called upload-artifact. Github is deprecating v3 of this action, so we need to update it or our workflows will fail.

Expected behavior

  • update upload-artifact to v4

Additional context

Example failed workflow
@amontanez24 amontanez24 added the maintenance Tasks related to infrastructure & dependencies label Feb 14, 2025
@amontanez24 amontanez24 self-assigned this Feb 14, 2025
@amontanez24 amontanez24 added this to the 1.18.0 milestone Feb 14, 2025
@amontanez24 amontanez24 mentioned this issue Feb 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amontanez24 amontanez24

Labels
maintenance Tasks related to infrastructure & dependencies
Projects
None yet
Milestone
1.18.0
Development

Successfully merging a pull request may close this issue.

Updating upload-artifact and download-artifact to v4 sdv-dev/SDV
1 participant
@amontanez24