fix(3277): Convert string "true" value to boolean for MySQL on banner list endpoint (#3298)

Author: y-oksaku

plugins/banners/list.js

@@ -23,14 +23,18 @@ module.exports = () => ({
         },
         handler: async (request, h) => {
             const { bannerFactory } = request.server.app;
-            const { scope } = request.query;
+            const { scope, isActive } = request.query;
 
             if (scope !== 'GLOBAL') {
                 if (!request.auth.isAuthenticated) {
                     throw boom.unauthorized('Authentication required');
                 }
             }
 
+            if (isActive !== undefined) {
+                request.query.isActive = ['true', true, '1', 1].includes(isActive);
+            }
+
             // list params defaults to empty object in models if undefined
             return bannerFactory
                 .list({ params: request.query })

test/plugins/banner.test.js

@@ -213,6 +213,7 @@ describe('banner plugin test', () => {
             bannerFactoryMock.list.resolves(getBannerMock(testBannersActive));
 
             return server.inject(options).then(reply => {
+                assert.calledWith(bannerFactoryMock.list, { params: { isActive: true, scope: 'GLOBAL' } });
                 assert.equal(reply.statusCode, 200);
                 assert.deepEqual(reply.result, testBannersActive);
             });