response changed and all semi-comma removed

Author: sagar-gavhane

.gitignore

@@ -59,3 +59,6 @@ typings/
 
 # next.js build output
 .next
+
+# serverless deploy output
+.serverless

index.js

@@ -1,80 +1,126 @@
-const express = require('express');
-const serverless = require('serverless-http');
-const bodyParser = require('body-parser');
-const pool = require('./configs/dbConfig');
+const express = require('express')
+const serverless = require('serverless-http')
+const bodyParser = require('body-parser')
+const pool = require('./configs/dbConfig')
 
-const app = express();
+const app = express()
 
-app.use(bodyParser.json());
-app.use(bodyParser.urlencoded({ extended: false }));
+app.use(bodyParser.json())
+app.use(bodyParser.urlencoded({ extended: true }))
 
-app.get(['/', '/pokemon/'], (req, res) => {
-  pool.query('SELECT * FROM pokemon_tb', (err, results, fields) => {
-    if (err){
-      res.send({ data: null, status: 400, error: err.message });
+app.get('/pokemon/', (req, res) => {
+  const query = 'SELECT * FROM pokemon_tb'
+  pool.query(query, (err, results, fields) => {
+    if (err) {
+      const response = { data: null, message: err.message, }
+      res.send(response)
     }
 
-    const pokemons = [...results];
-    res.send({ data: pokemons });
-  });
-});
+    const pokemons = [...results]
+    const response = {
+      data: pokemons,
+      message: 'All pokemons successfully retrieved.',
+    }
+    res.send(response)
+  })
+})
 
 app.get('/pokemon/:id', (req, res) => {
-  const id = req.params.id;
-  pool.query(`SELECT * FROM pokemon_tb WHERE id=${id}`, (err, results, fields) => {
+  const id = req.params.id
+  const query = `SELECT * FROM pokemon_tb WHERE id=${id}`
+  pool.query(query, (err, results, fields) => {
     if (err) {
-      res.send({ data: null, status: 400, error: err.message });
+      const response = { data: null, message: err.message, }
+      res.send(response)
     }
 
-    const pokemon = results[0];
-    res.send({data: pokemon});
-  });
-});
+    const pokemon = results[0]
+    const response = {
+      data: pokemon,
+      message: `Pokemon ${pokemon.name} successfully retrieved.`,
+    }
+    res.status(200).send(response)
+  })
+})
 
+// Handle pokemon POST route
 app.post('/pokemon/', (req, res) => {
-  const { name, height, weight, avatar } = req.body;
-  const query = `INSERT INTO pokemon_tb (name, height, weight, avatar) VALUES ('${name}', '${height}', '${weight}', '${avatar}')`;
+  const { name, height, weight, avatar } = req.body
+
+  const query = `INSERT INTO pokemon_tb (name, height, weight, avatar) VALUES ('${name}', '${height}', '${weight}', '${avatar}')`
   pool.query(query, (err, results, fields) => {
     if (err) {
-      res.send({ data: null, status: 400, error: err.message });
+      const response = { data: null, message: err.message, }
+      res.send(response)
+    }
+
+    const { insertId } = results
+    const pokemon = { id: insertId, name, height, weight, avatar }
+    const response = {
+      data: pokemon,
+      message: `Pokemon ${name} successfully added.`,
     }
-    const { insertId } = results;
-    const insertedPokemon = { id: insertId, name, height, weight, avatar };
-    res.send({ data: insertedPokemon });
-  });
-});
+    res.status(201).send(response)
+  })
+})
 
+// Handle pokemon PUT route
 app.put('/pokemon/:id', (req, res) => {
-  const id = req.params.id;
-  pool.query(`SELECT * FROM pokemon_tb WHERE id=${id} LIMIT 1`, (err, results, fields) => {
+  const { id } = req.params
+  const query = `SELECT * FROM pokemon_tb WHERE id=${id} LIMIT 1`
+  pool.query(query, (err, results, fields) => {
     if (err) {
-      res.send({ data: null, status: 400, error: err.message });
+      const response = { data: null, message: err.message, }
+      res.send(response)
     }
 
-    const { id, name, height, weight, avatar } = {...results[0], ...req.body};
-    const query = `UPDATE pokemon_tb SET name='${name}', height='${height}', weight='${weight}', avatar='${avatar}' WHERE id='${id}'`;
+    const { id, name, height, weight, avatar } = { ...results[0], ...req.body }
+    const query = `UPDATE pokemon_tb SET name='${name}', height='${height}', weight='${weight}', avatar='${avatar}' WHERE id='${id}'`
     pool.query(query, (err, results, fields) => {
       if (err) {
-        res.send({ data: null, status: 400, error: err.message });
+        const response = { data: null, message: err.message, }
+        res.send(response)
       }
 
-      res.send({ data: { id, name, height, weight, avatar } });
-    });
-  });
-});
+      const pokemon = {
+        id,
+        name,
+        height,
+        weight,
+        avatar,
+      }
+      const response = {
+        data: pokemon,
+        message: `Pokemon ${name} is successfully updated.`,
+      }
+      res.send(response)
+    })
+  })
+})
 
+// Handler pokemon DELETE route
 app.delete('/pokemon/:id', (req, res) => {
-  const id = req.params.id;
-  pool.query(`DELETE FROM pokemon_tb WHERE id='${id}'`, (err, results, fields) => {
+  const { id } = req.params
+  const query = `DELETE FROM pokemon_tb WHERE id=${id}`
+  pool.query(query, (err, results, fields) => {
     if (err) {
-      res.send({ data: null, status: 400, error: err.message });
+      const response = { data: null, message: err.message }
+      res.send(response)
+    }
+
+    const response = {
+      data: null,
+      message: `Pokemon with id: ${id} successfully deleted.`,
     }
-    res.send({ data: null, message: 'Pokemon successfully deleted'});
-  });
-});
+    res.send(response)
+  })
+})
 
-app.all('*', function(req, res){
-  res.send({ data: null, message: '404 - Route not found!!' });
-});
+// Handle in-valid route path
+app.all('*', function(req, res) {
+  const response = { data: null, message: 'Route not found!!' }
+  res.status(400).send(response)
+})
 
-module.exports.handler = serverless(app);
+// wrap express app instance with serverless http function
+module.exports.handler = serverless(app)