Rewrite location add function and add tests

Author: wesleylancel

app/models/opportunity.rb

@@ -316,7 +316,13 @@ def set_location_city
   def add_opportunity_locations_to_team
     geocoded_all = true
     self.location.split('|').each do |location_string|
-      geocoded_all &&= self.team.team_locations.where(conditions: ['address LIKE ?', "%#{location_string}%"]).exists? or anywhere?(location_string) ? false : self.team.team_locations.build(address: location_string, name: location_string).geocode
+      # skip if location is anywhere or already exists
+      if anywhere?(location_string) || self.team.team_locations.where(address: /.*#{location_string}.*/).count > 0
+        geocoded_all = false
+        next
+      end
+
+      geocoded_all &&= self.team.team_locations.build(address: location_string, name: location_string).geocode
     end
     geocoded_all || nil
   end

spec/models/opportunity_spec.rb

@@ -101,4 +101,37 @@
       job.has_application_from?(user).should be_true
     end
   end
+
+  describe "changing job location" do
+    it "should set location_city" do
+      job = Fabricate(:job)
+      job.location = "Amsterdam|San Francisco"
+      job.save
+      (job.location_city.split("|") - ["Amsterdam", "San Francisco"]).should == []
+    end
+
+    it "should not add anywhere to location_city" do
+      job = Fabricate(:job)
+      job.location = "Amsterdam|San Francisco|anywhere"
+      job.save
+      (job.location_city.split("|") - ["Amsterdam", "San Francisco"]).should == []
+    end
+
+    it "should update location_city with changes" do
+      job = Fabricate(:job)
+      job.location = "Amsterdam|San Francisco"
+      job.save
+      (job.location_city.split("|") - ["Amsterdam", "San Francisco"]).should == []
+      job.location = "Amsterdam"
+      job.save
+      job.location_city.should == "Amsterdam"
+    end
+
+    it "should not add existing locations to the team" do
+      job = Fabricate(:job)
+      job.location = "San Francisco"
+      job.save
+      job.team.team_locations.count.should === 1
+    end
+  end
 end