Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util.js window & document getAttribute/setAttribute not working with google maps streetview #67

Closed
philipp-winterle opened this issue Aug 3, 2017 · 5 comments

Comments

@philipp-winterle
Copy link

philipp-winterle commented Aug 3, 2017

Problem
If you are using lightgallery.js with google maps on the same page (both libraries included) and want to use Google Maps Street View you will not be able to, because the lightgallery hardcoded functions for "getAttribute" and "setAttribute" on window and document will conflict with Google Maps Street View

Request
Remove these functions from window and document and use a util function instead.

Pull Request already added to #68

@4skinSkywalker
Copy link

Same problem here. Please resolve

@philipp-winterle
Copy link
Author

I guess the maintainer is not interested in PRs. Sadly

@bio
Copy link

bio commented Aug 14, 2018

I got the same issue. Please review PR.

@sophielevens
Copy link

Thanks for the solution @hummal.

Is there a reason that this hasn't been reviewed or merged? This is a blocker for us and we would really appreciate it, we are reliant on this plugin working alongside Google maps.

Thanks!

@sachinchoolur
Copy link
Owner

Guys,
The issue has been fixed. Sorry for the delay.
@hummal Thank you for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants