Skip to content

Commit 12c7b00

Browse files
authored
perf: Removes log and multiple slicing
1 parent 18d3343 commit 12c7b00

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

src/baseroo.ts

+7-6
Original file line numberDiff line numberDiff line change
@@ -87,14 +87,15 @@ export function convertBase(value: string, fromBase: number, toBase: number): st
8787
}
8888

8989
const [integerPart, fractionalPart = ''] = value.split('.')
90-
91-
const base10Integer = convertToBase10Integer(integerPart, range.slice(0, fromBase))
92-
const toBaseInteger = convertFromBase10Integer(base10Integer, range.slice(0, toBase))
90+
const fromRange = range.slice(0, fromBase)
91+
const toRange = range.slice(0, toBase)
92+
93+
const base10Integer = convertToBase10Integer(integerPart, fromRange)
94+
const toBaseInteger = convertFromBase10Integer(base10Integer, toRange)
9395

9496
if (fractionalPart !== '') {
95-
const base10Fractional = convertToBase10Fractional(fractionalPart, range.slice(0, fromBase))
96-
const toBaseFractional = convertFromBase10Fractional(base10Fractional, range.slice(0, toBase))
97-
console.log({ value, base10Fractional, toBaseFractional })
97+
const base10Fractional = convertToBase10Fractional(fractionalPart, fromRange)
98+
const toBaseFractional = convertFromBase10Fractional(base10Fractional, toRange)
9899
return toBaseInteger + '.' + toBaseFractional
99100
}
100101

0 commit comments

Comments
 (0)