Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude index.html from published NPM package #38

Closed
melkorCBA opened this issue Feb 21, 2024 · 1 comment
Closed

Exclude index.html from published NPM package #38

melkorCBA opened this issue Feb 21, 2024 · 1 comment

Comments

@melkorCBA
Copy link

This issue stems from the presence of index.html within the project, which serves as an example. This file includes a vulnerable version of jQuery ([email protected]). Considering that this HTML file is merely an example and is not intended for direct usage within projects, its inclusion tends to pop up in vulnerability scanners like MEND (which is the case for me).

Proposed Solution:
excluding index.html from the npm package by adding it to the .npmignore file.

@ryanve
Copy link
Owner

ryanve commented Aug 15, 2024

thanks the page no longer uses jQuery since #39
keeping index.html in the package for sure
it's the project homepage and includes documentation

@ryanve ryanve closed this as completed Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants