Skip to content

Commit 962a08f

Browse files
authored
Merge pull request #716 from FractalFir/abi-cafe
Fixed some clippy warnings.
2 parents 395bca1 + b2b117e commit 962a08f

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

build_system/src/abi_test.rs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,13 +13,16 @@ fn show_usage() {
1313

1414
pub fn run() -> Result<(), String> {
1515
let mut args = std::env::args().skip(2);
16+
// FractalFir: In the future, I'd like to add some more subcommands / options.
17+
// So, this loop ought to stay for that purpose. It should also stay as a while loop(to parse args)
18+
#[allow(clippy::never_loop, clippy::while_let_on_iterator)]
1619
while let Some(arg) = args.next() {
1720
match arg.as_str() {
1821
"--help" => {
1922
show_usage();
2023
return Ok(());
2124
}
22-
_ => return Err(format!("Unknown option {}", arg)),
25+
_ => return Err(format!("Unknown option {arg:?}")),
2326
}
2427
}
2528
// Ensure that we have a cloned version of abi-cafe on hand.
@@ -56,7 +59,7 @@ pub fn run() -> Result<(), String> {
5659
&"c_calls_cg_gcc",
5760
];
5861
// Run ABI cafe.
59-
run_command_with_output(cmd, Some(&Path::new("clones/abi-cafe")))?;
62+
run_command_with_output(cmd, Some(Path::new("clones/abi-cafe")))?;
6063

6164
Ok(())
6265
}

0 commit comments

Comments
 (0)