Test suggestions in diagnostics with compiletest #45516
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
A-testsuite
Area: The testsuite used to check the correctness of rustc
C-enhancement
Category: An issue proposing an enhancement or a PR with one.
T-dev-tools
Relevant to the dev-tools subteam, which will review and decide on the PR/issue.
WG-diagnostics
Working group: Diagnostics
Currently suggestions are tested either via
compile-fail
// SUGGESTION foobar
comments or inui
tests by looking at the json or the command line output.The validity of these suggestions requires a human to interpret them. I suggest (pun intended) that we generate a
.suggestion
and a.suggestion.stderr
file together with the.stderr
and the.stdout
files. The file will only exist if there are any suggestions produced. The.suggestion
file will contain the source with all suggestions applied. The.suggestion.stderr
file will contain the result from compiling the.suggestion
file.Open questions:
cc @llogiq @Manishearth @mcarton
The text was updated successfully, but these errors were encountered: