-
Notifications
You must be signed in to change notification settings - Fork 13.2k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: rust-lang/rust
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: Manishearth/rust
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: rollup-xa514az
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
Can’t automatically merge.
Don’t worry, you can still create the pull request.
- 7 commits
- 9 files changed
- 2 contributors
Commits on Jul 19, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ea74e7d - Browse repository at this point
Copy the full SHA ea74e7dView commit details -
Rollup merge of #73618 - poliorcetics:false-keyword, r=jyn514
Documentation for the false keyword Partial fix of #34601. Short documentation for the false keyword mainly pointing to the `true` keyword.
Configuration menu - View commit details
-
Copy full SHA for bbd91d7 - Browse repository at this point
Copy the full SHA bbd91d7View commit details -
Rollup merge of #74495 - shepmaster:bootstrap-dist-target-files, r=Ma…
…rk-Simulacrum Teach bootstrap install and dist commands about TargetSelection With this, we can now use a target JSON file to build a cross-compiler: ``` x.py install --host ../aarch64-apple-darwin.json --target aarch64-apple-darwin ``` r? @Mark-Simulacrum
Configuration menu - View commit details
-
Copy full SHA for 59617e4 - Browse repository at this point
Copy the full SHA 59617e4View commit details -
Rollup merge of #74510 - LukasKalbertodt:fix-range-from-index-panic, …
…r=hanna-kruppe Fix panic message when `RangeFrom` index is out of bounds Before, the `Range` method was called with `end = slice.len()`. Unfortunately, because `Range::index` first checks the order of the indices (start has to be smaller than end), an out of bounds index leads to `core::slice::slice_index_order_fail` being called. This prints the message 'slice index starts at 27 but ends at 10', which is worse than 'index 27 out of range for slice of length 10'. This is not only useful to normal users reading panic messages, but also for people inspecting assembly and being confused by `slice_index_order_fail` calls. You can see the produced assembly [here](https://rust.godbolt.org/z/GzMGWf) and try on Playground [here](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=aada5996b2f3848075a6d02cf4055743). (By the way. this is only about which panic function is called; I'm pretty sure it does not improve anything about performance).
Configuration menu - View commit details
-
Copy full SHA for 89b814c - Browse repository at this point
Copy the full SHA 89b814cView commit details -
Rollup merge of #74514 - Mark-Simulacrum:nightly-rustc-docs, r=ollie27
Do not clobber RUSTDOCFLAGS We were setting these in both Builder::cargo and here, which ended up only setting the first of the two. Fixes #74511
Configuration menu - View commit details
-
Copy full SHA for 247ee15 - Browse repository at this point
Copy the full SHA 247ee15View commit details -
Rollup merge of #74523 - sollyucko:patch-1, r=Mark-Simulacrum
Improve documentation for `core::fmt` internals The public interface of `core::fmt` is well-documented, but the internals have very minimal documentation.
Configuration menu - View commit details
-
Copy full SHA for f72c304 - Browse repository at this point
Copy the full SHA f72c304View commit details -
Rollup merge of #74527 - calebcartwright:rustfmt-toolstate-maintainer…
…s, r=Mark-Simulacrum Add myself to toolstate change notifications for rustfmt I'd like to get the toolstate change notifications for rustfmt as well so that I'll know when things break. Have spoken with @topecongiro about this offline already.
Configuration menu - View commit details
-
Copy full SHA for ada334b - Browse repository at this point
Copy the full SHA ada334bView commit details
There are no files selected for viewing