Skip to content

Commit 2a990f7

Browse files
borsbors
committed
Auto merge of #99409 - tmiasko:atomic-tests, r=m-ou-se
Test codegen of atomic compare-exchange with additional memory orderings * Add a test for atomic operations introduced in #97423 & #98383. * Add a test for fallback code generation strategy used on LLVM 12 introduced in #98385. Use a separate test case instead of a revision system since test will be gone once LLVM 12 is no longer supported.
2 parents c32dcbb + 8ebaf14 commit 2a990f7

File tree

2 files changed

+109
-1
lines changed

2 files changed

+109
-1
lines changed

‎src/test/codegen/atomic-operations-llvm-12.rs

+84
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,84 @@
1+
// Code generation of atomic operations for LLVM 12
2+
// ignore-llvm-version: 13 - 99
3+
// compile-flags: -O
4+
#![crate_type = "lib"]
5+
6+
use std::sync::atomic::{AtomicI32, Ordering::*};
7+
8+
// CHECK-LABEL: @compare_exchange
9+
#[no_mangle]
10+
pub fn compare_exchange(a: &AtomicI32) {
11+
// CHECK: cmpxchg i32* %{{.*}}, i32 0, i32 10 monotonic monotonic
12+
// CHECK: cmpxchg i32* %{{.*}}, i32 0, i32 11 acquire acquire
13+
// CHECK: cmpxchg i32* %{{.*}}, i32 0, i32 12 seq_cst seq_cst
14+
let _ = a.compare_exchange(0, 10, Relaxed, Relaxed);
15+
let _ = a.compare_exchange(0, 11, Relaxed, Acquire);
16+
let _ = a.compare_exchange(0, 12, Relaxed, SeqCst);
17+
18+
// CHECK: cmpxchg i32* %{{.*}}, i32 0, i32 20 release monotonic
19+
// CHECK: cmpxchg i32* %{{.*}}, i32 0, i32 21 acq_rel acquire
20+
// CHECK: cmpxchg i32* %{{.*}}, i32 0, i32 22 seq_cst seq_cst
21+
let _ = a.compare_exchange(0, 20, Release, Relaxed);
22+
let _ = a.compare_exchange(0, 21, Release, Acquire);
23+
let _ = a.compare_exchange(0, 22, Release, SeqCst);
24+
25+
// CHECK: cmpxchg i32* %{{.*}}, i32 0, i32 30 acquire monotonic
26+
// CHECK: cmpxchg i32* %{{.*}}, i32 0, i32 31 acquire acquire
27+
// CHECK: cmpxchg i32* %{{.*}}, i32 0, i32 32 seq_cst seq_cst
28+
let _ = a.compare_exchange(0, 30, Acquire, Relaxed);
29+
let _ = a.compare_exchange(0, 31, Acquire, Acquire);
30+
let _ = a.compare_exchange(0, 32, Acquire, SeqCst);
31+
32+
// CHECK: cmpxchg i32* %{{.*}}, i32 0, i32 40 acq_rel monotonic
33+
// CHECK: cmpxchg i32* %{{.*}}, i32 0, i32 41 acq_rel acquire
34+
// CHECK: cmpxchg i32* %{{.*}}, i32 0, i32 42 seq_cst seq_cst
35+
let _ = a.compare_exchange(0, 40, AcqRel, Relaxed);
36+
let _ = a.compare_exchange(0, 41, AcqRel, Acquire);
37+
let _ = a.compare_exchange(0, 42, AcqRel, SeqCst);
38+
39+
// CHECK: cmpxchg i32* %{{.*}}, i32 0, i32 50 seq_cst monotonic
40+
// CHECK: cmpxchg i32* %{{.*}}, i32 0, i32 51 seq_cst acquire
41+
// CHECK: cmpxchg i32* %{{.*}}, i32 0, i32 52 seq_cst seq_cst
42+
let _ = a.compare_exchange(0, 50, SeqCst, Relaxed);
43+
let _ = a.compare_exchange(0, 51, SeqCst, Acquire);
44+
let _ = a.compare_exchange(0, 52, SeqCst, SeqCst);
45+
}
46+
47+
// CHECK-LABEL: @compare_exchange_weak
48+
#[no_mangle]
49+
pub fn compare_exchange_weak(w: &AtomicI32) {
50+
// CHECK: cmpxchg weak i32* %{{.*}}, i32 1, i32 10 monotonic monotonic
51+
// CHECK: cmpxchg weak i32* %{{.*}}, i32 1, i32 11 acquire acquire
52+
// CHECK: cmpxchg weak i32* %{{.*}}, i32 1, i32 12 seq_cst seq_cst
53+
let _ = w.compare_exchange_weak(1, 10, Relaxed, Relaxed);
54+
let _ = w.compare_exchange_weak(1, 11, Relaxed, Acquire);
55+
let _ = w.compare_exchange_weak(1, 12, Relaxed, SeqCst);
56+
57+
// CHECK: cmpxchg weak i32* %{{.*}}, i32 1, i32 20 release monotonic
58+
// CHECK: cmpxchg weak i32* %{{.*}}, i32 1, i32 21 acq_rel acquire
59+
// CHECK: cmpxchg weak i32* %{{.*}}, i32 1, i32 22 seq_cst seq_cst
60+
let _ = w.compare_exchange_weak(1, 20, Release, Relaxed);
61+
let _ = w.compare_exchange_weak(1, 21, Release, Acquire);
62+
let _ = w.compare_exchange_weak(1, 22, Release, SeqCst);
63+
64+
// CHECK: cmpxchg weak i32* %{{.*}}, i32 1, i32 30 acquire monotonic
65+
// CHECK: cmpxchg weak i32* %{{.*}}, i32 1, i32 31 acquire acquire
66+
// CHECK: cmpxchg weak i32* %{{.*}}, i32 1, i32 32 seq_cst seq_cst
67+
let _ = w.compare_exchange_weak(1, 30, Acquire, Relaxed);
68+
let _ = w.compare_exchange_weak(1, 31, Acquire, Acquire);
69+
let _ = w.compare_exchange_weak(1, 32, Acquire, SeqCst);
70+
71+
// CHECK: cmpxchg weak i32* %{{.*}}, i32 1, i32 40 acq_rel monotonic
72+
// CHECK: cmpxchg weak i32* %{{.*}}, i32 1, i32 41 acq_rel acquire
73+
// CHECK: cmpxchg weak i32* %{{.*}}, i32 1, i32 42 seq_cst seq_cst
74+
let _ = w.compare_exchange_weak(1, 40, AcqRel, Relaxed);
75+
let _ = w.compare_exchange_weak(1, 41, AcqRel, Acquire);
76+
let _ = w.compare_exchange_weak(1, 42, AcqRel, SeqCst);
77+
78+
// CHECK: cmpxchg weak i32* %{{.*}}, i32 1, i32 50 seq_cst monotonic
79+
// CHECK: cmpxchg weak i32* %{{.*}}, i32 1, i32 51 seq_cst acquire
80+
// CHECK: cmpxchg weak i32* %{{.*}}, i32 1, i32 52 seq_cst seq_cst
81+
let _ = w.compare_exchange_weak(1, 50, SeqCst, Relaxed);
82+
let _ = w.compare_exchange_weak(1, 51, SeqCst, Acquire);
83+
let _ = w.compare_exchange_weak(1, 52, SeqCst, SeqCst);
84+
}

‎src/test/codegen/atomic-operations.rs

+25-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// Code generation of atomic operations.
2-
//
2+
// min-llvm-version: 13.0
33
// compile-flags: -O
44
#![crate_type = "lib"]
55

@@ -9,20 +9,32 @@ use std::sync::atomic::{AtomicI32, Ordering::*};
99
#[no_mangle]
1010
pub fn compare_exchange(a: &AtomicI32) {
1111
// CHECK: cmpxchg {{i32\*|ptr}} %{{.*}}, i32 0, i32 10 monotonic monotonic
12+
// CHECK: cmpxchg {{i32\*|ptr}} %{{.*}}, i32 0, i32 11 monotonic acquire
13+
// CHECK: cmpxchg {{i32\*|ptr}} %{{.*}}, i32 0, i32 12 monotonic seq_cst
1214
let _ = a.compare_exchange(0, 10, Relaxed, Relaxed);
15+
let _ = a.compare_exchange(0, 11, Relaxed, Acquire);
16+
let _ = a.compare_exchange(0, 12, Relaxed, SeqCst);
1317

1418
// CHECK: cmpxchg {{i32\*|ptr}} %{{.*}}, i32 0, i32 20 release monotonic
19+
// CHECK: cmpxchg {{i32\*|ptr}} %{{.*}}, i32 0, i32 21 release acquire
20+
// CHECK: cmpxchg {{i32\*|ptr}} %{{.*}}, i32 0, i32 22 release seq_cst
1521
let _ = a.compare_exchange(0, 20, Release, Relaxed);
22+
let _ = a.compare_exchange(0, 21, Release, Acquire);
23+
let _ = a.compare_exchange(0, 22, Release, SeqCst);
1624

1725
// CHECK: cmpxchg {{i32\*|ptr}} %{{.*}}, i32 0, i32 30 acquire monotonic
1826
// CHECK: cmpxchg {{i32\*|ptr}} %{{.*}}, i32 0, i32 31 acquire acquire
27+
// CHECK: cmpxchg {{i32\*|ptr}} %{{.*}}, i32 0, i32 32 acquire seq_cst
1928
let _ = a.compare_exchange(0, 30, Acquire, Relaxed);
2029
let _ = a.compare_exchange(0, 31, Acquire, Acquire);
30+
let _ = a.compare_exchange(0, 32, Acquire, SeqCst);
2131

2232
// CHECK: cmpxchg {{i32\*|ptr}} %{{.*}}, i32 0, i32 40 acq_rel monotonic
2333
// CHECK: cmpxchg {{i32\*|ptr}} %{{.*}}, i32 0, i32 41 acq_rel acquire
34+
// CHECK: cmpxchg {{i32\*|ptr}} %{{.*}}, i32 0, i32 42 acq_rel seq_cst
2435
let _ = a.compare_exchange(0, 40, AcqRel, Relaxed);
2536
let _ = a.compare_exchange(0, 41, AcqRel, Acquire);
37+
let _ = a.compare_exchange(0, 42, AcqRel, SeqCst);
2638

2739
// CHECK: cmpxchg {{i32\*|ptr}} %{{.*}}, i32 0, i32 50 seq_cst monotonic
2840
// CHECK: cmpxchg {{i32\*|ptr}} %{{.*}}, i32 0, i32 51 seq_cst acquire
@@ -36,20 +48,32 @@ pub fn compare_exchange(a: &AtomicI32) {
3648
#[no_mangle]
3749
pub fn compare_exchange_weak(w: &AtomicI32) {
3850
// CHECK: cmpxchg weak {{i32\*|ptr}} %{{.*}}, i32 1, i32 10 monotonic monotonic
51+
// CHECK: cmpxchg weak {{i32\*|ptr}} %{{.*}}, i32 1, i32 11 monotonic acquire
52+
// CHECK: cmpxchg weak {{i32\*|ptr}} %{{.*}}, i32 1, i32 12 monotonic seq_cst
3953
let _ = w.compare_exchange_weak(1, 10, Relaxed, Relaxed);
54+
let _ = w.compare_exchange_weak(1, 11, Relaxed, Acquire);
55+
let _ = w.compare_exchange_weak(1, 12, Relaxed, SeqCst);
4056

4157
// CHECK: cmpxchg weak {{i32\*|ptr}} %{{.*}}, i32 1, i32 20 release monotonic
58+
// CHECK: cmpxchg weak {{i32\*|ptr}} %{{.*}}, i32 1, i32 21 release acquire
59+
// CHECK: cmpxchg weak {{i32\*|ptr}} %{{.*}}, i32 1, i32 22 release seq_cst
4260
let _ = w.compare_exchange_weak(1, 20, Release, Relaxed);
61+
let _ = w.compare_exchange_weak(1, 21, Release, Acquire);
62+
let _ = w.compare_exchange_weak(1, 22, Release, SeqCst);
4363

4464
// CHECK: cmpxchg weak {{i32\*|ptr}} %{{.*}}, i32 1, i32 30 acquire monotonic
4565
// CHECK: cmpxchg weak {{i32\*|ptr}} %{{.*}}, i32 1, i32 31 acquire acquire
66+
// CHECK: cmpxchg weak {{i32\*|ptr}} %{{.*}}, i32 1, i32 32 acquire seq_cst
4667
let _ = w.compare_exchange_weak(1, 30, Acquire, Relaxed);
4768
let _ = w.compare_exchange_weak(1, 31, Acquire, Acquire);
69+
let _ = w.compare_exchange_weak(1, 32, Acquire, SeqCst);
4870

4971
// CHECK: cmpxchg weak {{i32\*|ptr}} %{{.*}}, i32 1, i32 40 acq_rel monotonic
5072
// CHECK: cmpxchg weak {{i32\*|ptr}} %{{.*}}, i32 1, i32 41 acq_rel acquire
73+
// CHECK: cmpxchg weak {{i32\*|ptr}} %{{.*}}, i32 1, i32 42 acq_rel seq_cst
5174
let _ = w.compare_exchange_weak(1, 40, AcqRel, Relaxed);
5275
let _ = w.compare_exchange_weak(1, 41, AcqRel, Acquire);
76+
let _ = w.compare_exchange_weak(1, 42, AcqRel, SeqCst);
5377

5478
// CHECK: cmpxchg weak {{i32\*|ptr}} %{{.*}}, i32 1, i32 50 seq_cst monotonic
5579
// CHECK: cmpxchg weak {{i32\*|ptr}} %{{.*}}, i32 1, i32 51 seq_cst acquire

0 commit comments

Comments
 (0)