Skip to content
This repository was archived by the owner on Apr 23, 2020. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: llvm-mirror/lldb
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: rust-lang/lldb
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: rust-release-80-v2
Choose a head ref
  • 18 commits
  • 56 files changed
  • 1 contributor

Commits on Nov 27, 2018

  1. Add Rust support to Mangled 

    This adds Rust support to Mangled.  I am not completely certain that
this is needed (or alternatively that it does enough, maybe
Mangled::GuessLanguage needs a Rust case).  This should be checked
before attempting to upstream.
    @tromey
    tromey committed Nov 27, 2018
    Copy the full SHA
    8bbb72a View commit details

  2. Add DIERef::operator== 

    This was needed for the Rust plugin
    @tromey
    tromey committed Nov 27, 2018

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    707df0a View commit details

  3. Add a missing TypeAndOrName constructor 

    Add a TypeAndOrName constructor that was declared but not defined.
This is used in the Rust plugin.  See https://reviews.llvm.org/D44752
    @tromey
    tromey committed Nov 27, 2018
    Copy the full SHA
    e8ba344 View commit details

  4. Add Rust support to the Python test harness

    @tromey
    tromey committed Nov 27, 2018

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    0a642db View commit details

  5. The Rust plugin

    @tromey
    tromey committed Nov 27, 2018
    Copy the full SHA
    a0fc10c View commit details

  6. Compute Python library suffix in CMakeLists.txt 

    Introduce LLDB_PY_LIB_SUFFIX and use it in various places in the
build.  This lets the x.py-based build work properly without having to
set LLVM_LIBDIR_SUFFIX.

See https://bugs.llvm.org/show_bug.cgi?id=18957 for some discussion.
    @tromey
    tromey committed Nov 27, 2018
    Copy the full SHA
    8e114ff View commit details

  7. Do not crash when enum discriminant is not recognized 

    Sometimes the DWARF can omit information about a discriminant, for
example when an Option shares a discriminant slot with an enum that it
wraps.  In this case, lldb could crash, because the discriminant was
not found and because there was no default variant.

No test case because this relies on a compiler bug that will soon be
fixed.

Fixes #16
    @tromey
    tromey committed Nov 27, 2018
    Copy the full SHA
    774fbad View commit details

  8. Use correct include path for State.h 

    While rebasing to master, I missed a spot where an include file was
moved.  I believe my local build was picking up an installed copy of
the header, causing it to succeed locally.
    @tromey
    tromey committed Nov 27, 2018
    Copy the full SHA
    49b1456 View commit details

  9. Add "rust-enabled" to --version output 

    This adds "rust-enabled" to the --version output, so it's easier to
tell if lldb has rust support.
    @tromey
    tromey committed Nov 27, 2018
    Copy the full SHA
    f53e334 View commit details

  10. Fix handling of variant parts 

    This fixes a couple of problems noticed while debugging the rust
compiler change to use DW_TAG_variant_part:

* IterableDIEChildren returned one extra DIE, because it did not
  preserve the CU in end()

* The entire block dealing with DW_TAG_variant_part was erroneously
  inside the DW_TAG_member case.
    @tromey
    tromey committed Nov 27, 2018
    Copy the full SHA
    ac55308 View commit details

  11. Give names to tuple fields 

    This gives numeric names to tuple fields, because lldb clients expect
fields to have names, and because using plain numbers seemed most
rust-like.

Closes #21
    @tromey
    tromey committed Nov 27, 2018
    Copy the full SHA
    94380a7 View commit details

  12. Rename tuple fields after discriminant is removed 

    When the discriminant is removed from an enum's members, be sure to
rename the fields of any tuple type.  This fixes a bug introduced in
yesterday's patch.
    @tromey
    tromey committed Nov 27, 2018
    Copy the full SHA
    54cafd1 View commit details

  13. Fix field names when emitting a C structure 

    Prepend an underscore to field names when emitting a C structure, to
ensure that tuple fields have valid names.
    @tromey
    tromey committed Nov 27, 2018
    Copy the full SHA
    f2dc66a View commit details

  14. Remove by-name cache from RustASTContext 

    Remove the by-name cache from RustASTContext.  This was not needed and
could interact badly with the DWARF parser.  Closes #22
    @tromey
    tromey committed Nov 27, 2018
    Copy the full SHA
    fb2a1e7 View commit details

  15. Disable enum type test 

    This disables aaan enum type name test that is failing with git master
rustc.  See #24.
    @tromey
    tromey committed Nov 27, 2018
    Copy the full SHA
    5ec9375 View commit details

  16. Read template parameters for structure types 

    Read DW_TAG_template_type_parameter and apply to structure types.
    @tromey
    tromey committed Nov 27, 2018
    Copy the full SHA
    47ae5a9 View commit details

  17. Read template parameters for function types 

    Read DW_TAG_template_type_parameter and apply to function types.

Closes #5
    @tromey
    tromey committed Nov 27, 2018
    Copy the full SHA
    403f869 View commit details

  18. Fix the build after the rebase 

    The rebase onto a later git master lldb required a change to
RustASTContext.
    @tromey
    tromey committed Nov 27, 2018
    Copy the full SHA
    8ad0817 View commit details
Loading