Convert all python objects in our API to use overload the __str__ method

instead of the __repr__. __repr__ is a function that should return an
expression that can be used to recreate an python object and we were using
it to just return a human readable string.

Fixed a crasher when using the new implementation of SBValue::Cast(SBType).

Thread hardened lldb::SBValue and lldb::SBWatchpoint and did other general
improvements to the API.

Fixed a crasher in lldb::SBValue::GetChildMemberWithName() where we didn't
correctly handle not having a target.




git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@149743 91177308-0d34-0410-b5e6-96231b3b80d8

Author: Greg Clayton

include/lldb/API/SBType.h

@@ -167,6 +167,9 @@ class SBType
     const lldb_private::TypeImpl &
     ref () const;
 
+    lldb::TypeImplSP
+    GetSP ();
+
     void
     SetSP (const lldb::TypeImplSP &type_impl_sp);
 #endif

include/lldb/API/SBValue.h

@@ -355,27 +355,13 @@ class SBValue
     friend class SBValueList;
     friend class SBFrame;
 
-#ifndef SWIG
-    // Mimic shared pointer...
-    lldb_private::ValueObject *
-    get() const;
-
-    lldb_private::ValueObject *
-    operator->() const;
-
-    lldb::ValueObjectSP &
-    operator*();
-
-    const lldb::ValueObjectSP &
-    operator*() const;
-
-#endif
-
+    lldb::ValueObjectSP
+    GetSP () const;
+    
+    void
+    SetSP (const lldb::ValueObjectSP &sp);
+    
 private:
-    // Helper function for SBValue::Watch() and SBValue::WatchPointee().
-    lldb::SBWatchpoint
-    WatchValue(bool read, bool write, bool watch_pointee);
-
     lldb::ValueObjectSP m_opaque_sp;
 };
 

include/lldb/API/SBWatchpoint.h

@@ -22,12 +22,12 @@ class SBWatchpoint
 
     SBWatchpoint (const lldb::SBWatchpoint &rhs);
 
+    SBWatchpoint (const lldb::WatchpointSP &wp_sp);
+
     ~SBWatchpoint ();
 
-#ifndef SWIG
     const lldb::SBWatchpoint &
     operator = (const lldb::SBWatchpoint &rhs);
-#endif
 
     bool
     IsValid() const;
@@ -72,27 +72,20 @@ class SBWatchpoint
     bool
     GetDescription (lldb::SBStream &description, DescriptionLevel level);
 
-#ifndef SWIG
-    SBWatchpoint (const lldb::WatchpointSP &wp_sp);
-#endif
+    void
+    Clear ();
+
+    lldb::WatchpointSP
+    GetSP () const;
+
+    void
+    SetSP (const lldb::WatchpointSP &sp);
 
 private:
     friend class SBTarget;
     friend class SBValue;
 
-#ifndef SWIG
-
-    lldb_private::Watchpoint *
-    operator->();
-
-    lldb_private::Watchpoint *
-    get();
-
-    lldb::WatchpointSP &
-    operator *();
-
-#endif
-
+    
     lldb::WatchpointSP m_opaque_sp;
 
 };

include/lldb/Core/ValueObject.h

@@ -518,6 +518,9 @@ class ValueObject : public UserID
     virtual ConstString
     GetTypeName() = 0;
 
+    //------------------------------------------------------------------
+    // Sublasses can implement the functions below.
+    //------------------------------------------------------------------
     virtual lldb::LanguageType
     GetObjectRuntimeLanguage();
 
@@ -632,6 +635,10 @@ class ValueObject : public UserID
             return m_parent->GetModule();
         return NULL;
     }
+    
+    virtual bool
+    GetDeclaration (Declaration &decl);
+
     //------------------------------------------------------------------
     // The functions below should NOT be modified by sublasses
     //------------------------------------------------------------------

include/lldb/Core/ValueObjectDynamicValue.h

@@ -22,6 +22,11 @@ namespace lldb_private {
     class ValueObjectCast : public ValueObject
     {
     public:
+        static lldb::ValueObjectSP
+        Create (ValueObject &parent, 
+                const ConstString &name, 
+                const ClangASTType &cast_type);
+
         virtual
         ~ValueObjectCast();
 
@@ -83,7 +88,6 @@ namespace lldb_private {
         ClangASTType m_cast_type;
 
     private:
-        friend class ValueObject;
         ValueObjectCast (ValueObject &parent, 
                          const ConstString &name, 
                          const ClangASTType &cast_type);

include/lldb/Core/ValueObjectVariable.h

@@ -58,6 +58,9 @@ class ValueObjectVariable : public ValueObject
     virtual SymbolContextScope *
     GetSymbolContextScope();
 
+    virtual bool
+    GetDeclaration (Declaration &decl);
+
 protected:
     virtual bool
     UpdateValue ();

include/lldb/Symbol/ClangASTType.h

@@ -301,7 +301,7 @@ class ClangASTType
 						 uint32_t& stride);
 
     lldb::clang_type_t
-    GetPointerType ();
+    GetPointerType () const;
 
     static lldb::clang_type_t
     GetPointerType (clang::ASTContext *ast_context,