Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the width for the content be increased? #1559

Open
MaikKlein opened this issue Nov 22, 2018 · 7 comments
Open

Should the width for the content be increased? #1559

MaikKlein opened this issue Nov 22, 2018 · 7 comments
Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works

Comments

@MaikKlein
Copy link

First of all I am not a webdev.

I always felt that crates.io looks a bit cramped on my desktop machine.

For example this is how it currently looks

After I changed the width

Now it has the same size as Github. I personally think this would be an improvement, what do you think?

@carols10cents
Copy link
Member

Having the README be the same width as GitHub, at least for crate show pages, would probably be nice. Not sure if that should extend to search pages or settings pages or the other pages we have, and if not, if it would be weird that the widths change...

@carols10cents carols10cents added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-design labels Dec 6, 2018
@moonheart08
Copy link

Maybe make it.. not be fixed width? Please? Screen sizes above 16:9 really suffer, and a lot of screen space is wasted. Pictured is a 21:9 display viewing crates.io.
image

@miDeb
Copy link

miDeb commented Nov 1, 2020

There was already an issue for that (#970), but if you go to the linked page https://crates.io/crates/colorparse today, it looks more like the "before" in the gif of the closing pr #1064. Maybe that's even a regression?

@ibaryshnikov
Copy link

Hi all! What's the state of this issue? Any desire to make a change for wider screens? It looks like here's the place responsible for the docs width

.docs {
@media only screen and (min-width: 890px) {
flex: 7;
padding-right: 20px;
max-width: 640px;
}
}

@Turbo87
Copy link
Member

Turbo87 commented Mar 4, 2021

we're slowly working towards a state of the code where we should be able to increase the width without too many issues :)

@ibaryshnikov
Copy link

Does it break something else when increased?

@Turbo87
Copy link
Member

Turbo87 commented Dec 23, 2021

@ibaryshnikov yes, see #3687 (comment) for example 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-frontend 🐹 C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

No branches or pull requests

6 participants