Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RecoveryId should be an enum #727

Closed
Kixunil opened this issue Aug 27, 2024 · 0 comments · Fixed by #743
Closed

RecoveryId should be an enum #727

Kixunil opened this issue Aug 27, 2024 · 0 comments · Fixed by #743
Labels
API hole Important API missing - significantly degrades usability or idiomatic usage

Comments

@Kixunil
Copy link
Collaborator

Kixunil commented Aug 27, 2024

It has only four valid values and they're not going to change, so it should be an enum. Or at least conversion to u8 and from u8 should be available.
@Kixunil Kixunil added the API hole Important API missing - significantly degrades usability or idiomatic usage label Aug 27, 2024
@liamaharon liamaharon mentioned this issue Sep 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API hole Important API missing - significantly degrades usability or idiomatic usage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make RecoveryId an enum liamaharon/rust-secp256k1
1 participant
@Kixunil