Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using 'squash and merge' #453

Closed
maschwenk opened this issue Jan 3, 2018 · 1 comment
Closed

Consider using 'squash and merge' #453

maschwenk opened this issue Jan 3, 2018 · 1 comment

Comments

@maschwenk
Copy link
Contributor

maschwenk commented Jan 3, 2018

First of all, I'm a 2 time contributor and really appreciate your work here.

I just have a minor suggestion for you. Looking at the commit history on master, I see a lot of WIP/git revert style commits. While I think these can be valuable in the PR timeline like here (#448), I think you may make it easier for you to follow the commit history by using the Squash and merge button when you merge PR's. We've done this in my org/personal projects and it's really great. If you want to look at why you abandoned a certain approach in the life of a PR, you always have the PR link to go back to, but when you look long term at changes to the repo, it'll be a more coherent linear changelog.

Just a thought. It also helps contributors coming from the outside have a more concise picture of how single files changed through history/blame

image

@phstc
Copy link
Collaborator

phstc commented Jan 3, 2018

@maschwenk you are right, it's a great idea. I will start doing more squash from now on.

@phstc phstc closed this as completed Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants