add ORPHANED that shows both end-of-life and unmaintaned #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please remove the "UNMAINTAINED" keyword in favor of this new one. I don't think we should add multiple keywords which are so similar (especially since "unmaintained" can easily be types manually). |
|
done
…--
◉ Kei Okada
2017-05-17 11:46 GMT+09:00 Dirk Thomas <[email protected]>:
Please remove the "UNMAINTAINED" keyword in favor of this new one. I don't
think we should add multiple keywords which are so similar (especially
since "unmaintained" can easily be types manually).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#439 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAeG3AoKEe3vkQLjEjYVejOIymdFgJPCks5r6l-VgaJpZM4NdTyV>
.
|
dirk-thomas
reviewed
May 17, 2017
| @@ -7,7 +7,7 @@ var QUERY_TRANSFORMS = { | |||
| 'RED1': '<td><a class="m"></a>', | |||
| 'RED2': '</a><a class="m"></a><a', | |||
| 'RED3': '<a class="m"></a></td>', | |||
| 'UNMAINTAINED' : '<span class="unmaintained"' | |||
| 'ORPHANED' : '<span class="unmaintained"|<span class="end-of-life"', | |||
There was a problem hiding this comment.
Please remove the trailing comma.
|
sorry, fixed
…--
◉ Kei Okada
2017-05-17 12:02 GMT+09:00 Dirk Thomas <[email protected]>:
***@***.**** commented on this pull request.
------------------------------
In ros_buildfarm/templates/status/js/setup.js
<#439 (comment)>
:
> @@ -7,7 +7,7 @@ var QUERY_TRANSFORMS = {
'RED1': '<td><a class="m"></a>',
'RED2': '</a><a class="m"></a><a',
'RED3': '<a class="m"></a></td>',
- 'UNMAINTAINED' : '<span class="unmaintained"'
+ 'ORPHANED' : '<span class="unmaintained"|<span class="end-of-life"',
Please remove the trailing comma.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#439 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAeG3L5199T6CuMqi1MdfC9F2EGDMGHzks5r6mMzgaJpZM4NdTyV>
.
|
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up of #434, since we have generic OR method in #436 (comment), but we already have UNMAINTAINED keyword, so this might be duplicates.