Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add UNMAINTAINED shortcut link #435

Merged
merged 1 commit into from
May 13, 2017
Merged

add UNMAINTAINED shortcut link #435

merged 1 commit into from
May 13, 2017

Conversation

k-okada
Copy link
Contributor

@k-okada k-okada commented May 13, 2017

simpler version of #434

@k-okada
Copy link
Contributor Author

k-okada commented May 13, 2017

travis failed due to

0.05s$ sudo sh -c 'echo "deb http://packages.ros.org/ros/ubuntu $(lsb_release -sc) main" > /etc/apt/sources.list.d/ros.list'
120.11s$ sudo apt-key adv --keyserver hkp://ha.pool.sks-keyservers.net:80 --recv-key 421C365BD9FF1F717815A3895523BAEEB01FA116
Executing: gpg --ignore-time-conflict --no-options --no-default-keyring --homedir /tmp/tmp.HdYQVsoq8k --no-auto-check-trustdb --trust-model always --keyring /etc/apt/trusted.gpg --primary-keyring /etc/apt/trusted.gpg --keyring /etc/apt/trusted.gpg.d/apt.postgresql.org.gpg --keyserver hkp://ha.pool.sks-keyservers.net:80 --recv-key 421C365BD9FF1F717815A3895523BAEEB01FA116
gpg: requesting key B01FA116 from hkp server ha.pool.sks-keyservers.net
gpg: keyserver timed out
gpg: keyserver receive failed: keyserver error
The command "sudo apt-key adv --keyserver hkp://ha.pool.sks-keyservers.net:80 --recv-key 421C365BD9FF1F717815A3895523BAEEB01FA116" failed and exited with 2 during .
Your build has been stopped.

@k-okada k-okada mentioned this pull request May 13, 2017
Open
dirk-thomas
dirk-thomas reviewed May 13, 2017
View reviewed changes
Copy link
Member

@dirk-thomas dirk-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simpler version of #434

Please close the duplicate PR if it is obsolete.

I am not sure if this query justifies a new link. The user can simply type "unmaintained" into the search box since there is no "magic" / complex matching happening. Otherwise a link for "end of life", "unknown", etc. would also be helpful.

ros_buildfarm/templates/status/release_status_page.html.em Outdated
@@ -60,6 +60,7 @@
<a href="?q=ORANGE">ORANGE</a>,
<a href="?q=YELLOW">YELLOW</a>,
<a href="?q=GRAY">GRAY</a>
<a href="?q=UNMAINTAINED" title="Filter packages whth unmaintained or end-of-life status">UNMAINTAINED</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling: whth -> with

This query does not show packages with status "end of life". It only shows packages with status "unmaintained".

ros_buildfarm/templates/status/js/setup.js
@@ -6,7 +6,8 @@ var QUERY_TRANSFORMS = {
'GRAY': '<a class="i"></a>',
'RED1': '<td><a class="m"></a>',
'RED2': '</a><a class="m"></a><a',
'RED3': '<a class="m"></a></td>'
'RED3': '<a class="m"></a></td>',
'UNMAINTAINED' : '<span class="unmaintained"'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The query could just use the lower case search "unmaintained". I don't expect that token to appear in other parts of the status page beside the status column. Therefore this change is not necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand the code correctly, it is not likely happens, but in theory if someone make foo_unmaintaned_pkg package, then it does not work correctly,

@k-okada k-okada force-pushed the add_unmaintaned branch from 192b9ee to 1c44537 Compare May 13, 2017 14:52
@k-okada k-okada force-pushed the add_unmaintaned branch from 1c44537 to dda009c Compare May 13, 2017 14:54
@k-okada
Copy link
Contributor Author

k-okada commented May 13, 2017

#434 matches both end-of-life and unmaintained,
#435 matches only unmaintained
I personally think #435 is more helpful, but it requires a hack to search OR condition https://github.com/ros-infrastructure/ros_buildfarm/pull/434/files#diff-02b0305ea7fbc00c508896b48b82952bR271

@k-okada k-okada changed the title add ORPHANED shortcut link add UNMAINTAINED shortcut link May 13, 2017
@dirk-thomas
Copy link
Member

Thanks.

@dirk-thomas dirk-thomas merged commit ffd22ea into ros-infrastructure:master May 13, 2017
@dirk-thomas dirk-thomas mentioned this pull request May 13, 2017
Closed
dirk-thomas added a commit that referenced this pull request May 15, 2017
@dirk-thomas
add missing comma (#435)
4df621c
dirk-thomas
dirk-thomas reviewed May 15, 2017
View reviewed changes
ros_buildfarm/templates/status/release_status_page.html.em
@@ -60,6 +60,7 @@
<a href="?q=ORANGE">ORANGE</a>,
<a href="?q=YELLOW">YELLOW</a>,
<a href="?q=GRAY">GRAY</a>
<a href="?q=UNMAINTAINED" title="Filter packages with unmaintained status">UNMAINTAINED</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed missing comma in 4df621c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirk-thomas dirk-thomas dirk-thomas left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-okada @dirk-thomas