Skip to content

Commit c761640

Browse files
committed
Merge pull request #228 from ros-infrastructure/fix_catkin_doc_job
fix catkin doc job
2 parents 5f73b59 + 8fa95d4 commit c761640

File tree

2 files changed

+13
-6
lines changed

2 files changed

+13
-6
lines changed

ros_buildfarm/templates/doc/doc_create_task.Dockerfile.em

+8-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# generated from @template_name
22

3-
FROM ubuntu:trusty
3+
FROM ubuntu:@os_code_name
44
MAINTAINER Dirk Thomas dthomas+buildfarm@@osrfoundation.org
55

66
VOLUME ["/var/cache/apt/archives"]
@@ -16,7 +16,7 @@ RUN useradd -u @uid -m buildfarm
1616
'snippet/add_distribution_repositories.Dockerfile.em',
1717
distribution_repository_keys=distribution_repository_keys,
1818
distribution_repository_urls=distribution_repository_urls,
19-
os_code_name='trusty',
19+
os_code_name=os_code_name,
2020
add_source=False,
2121
))@
2222

@@ -28,6 +28,12 @@ RUN useradd -u @uid -m buildfarm
2828
# automatic invalidation once every day
2929
RUN echo "@today_str"
3030

31+
@(TEMPLATE(
32+
'snippet/install_python3.Dockerfile.em',
33+
os_name=os_name,
34+
os_code_name=os_code_name,
35+
))@
36+
3137
RUN python3 -u /tmp/wrapper_scripts/apt-get.py update-and-install -q -y git mercurial python3-apt python3-catkin-pkg python3-empy python3-rosdep python3-rosdistro subversion
3238

3339
# always invalidate to actually have the latest apt and rosdep state

scripts/doc/build_doc.py

+5-4
Original file line numberDiff line numberDiff line change
@@ -86,13 +86,14 @@ def main(argv=sys.argv[1:]):
8686
args.output_dir, 'symbols', '%s.tag' % pkg_name)
8787

8888
source_cmd = [
89-
# for workspaces with only plain cmake packages the setup files
90-
# generated by cmi won't implicitly source the underlays
91-
'.', '/opt/ros/%s/setup.sh' % args.rosdistro_name,
92-
'&&',
9389
'.', os.path.join(
9490
args.workspace_root, 'install_isolated', 'setup.sh'),
9591
]
92+
# for workspaces with only plain cmake packages the setup files
93+
# generated by cmi won't implicitly source the underlays
94+
setup_file = '/opt/ros/%s/setup.sh' % args.rosdistro_name
95+
if os.path.exists(setup_file):
96+
source_cmd = ['.', setup_file] + source_cmd
9697
rosdoc_lite_cmd = [
9798
os.path.join(args.rosdoc_lite_dir, 'scripts', 'rosdoc_lite'),
9899
pkg_path,

0 commit comments

Comments
 (0)