Skip to content

Commit 558d1e6

Browse files
richardlauaduh95
authored andcommitted
build: warn for gcc versions earlier than 8.3.0
Update the warning threshold to match the minimum supported version of gcc. Builds can still proceed, but are not guaranteed to work. PR-URL: nodejs#37935 Refs: nodejs#37871 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 19ed27d commit 558d1e6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

configure.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -960,8 +960,8 @@ def check_compiler(o):
960960
('clang ' if is_clang else '', CXX, version_str))
961961
if not ok:
962962
warn('failed to autodetect C++ compiler version (CXX=%s)' % CXX)
963-
elif clang_version < (8, 0, 0) if is_clang else gcc_version < (6, 3, 0):
964-
warn('C++ compiler (CXX=%s, %s) too old, need g++ 6.3.0 or clang++ 8.0.0' %
963+
elif clang_version < (8, 0, 0) if is_clang else gcc_version < (8, 3, 0):
964+
warn('C++ compiler (CXX=%s, %s) too old, need g++ 8.3.0 or clang++ 8.0.0' %
965965
(CXX, version_str))
966966

967967
ok, is_clang, clang_version, gcc_version = try_check_compiler(CC, 'c')

0 commit comments

Comments
 (0)