Java record types being formatted incorrectly

[Naros]

Describe the bug
After upgrading to 2.25.0, all Java record types are being reformatted.

For example, given the following record declaration:

public record FirstHeader(int totalBytes, int offset, int size, OffsetStatus status) {
    public boolean hasData() {
        return status == OffsetStatus.MORE_DATA_NEW_OFFSET || offset > 0;
    }
}

After running the formatted, the output yields:

public record FirstHeader(int totalBytes,int offset,int size,OffsetStatus status){

public boolean hasData(){return status==OffsetStatus.MORE_DATA_NEW_OFFSET||offset>0;}}

What is being lost here are the following:

• Indentation to match the same indentation observed inside classes
• Spaces after commas in the record's definition
• Spaces before { at the end of of declaration and methods
• Spaces before and after operators like ||, ==, >.

Expected behavior

When the record is formatted using 2.24.1, we observe the correct formatting. But once we upgraded to 2.25.0, I've observed these differences. I've reviewed all formatter configuration settings that include "record" in their names, setting their values as follows:

<profiles version="12">
  <profile kind="CodeFormatterProfile" name="Debezium" version="12">
        <!-- Various other settings -->
        <setting id="org.eclipse.jdt.core.formatter.alignment_for_record_components" value="16"/>
        <setting id="org.eclipse.jdt.core.formatter.alignment_for_superinterfaces_in_record_declaration" value="16"/>
        <setting id="org.eclipse.jdt.core.formatter.brace_position_for_record_constructor" value="end_of_line"/>
        <setting id="org.eclipse.jdt.core.formatter.brace_position_for_record_declaration" value="end_of_line"/>
        <setting id="org.eclipse.jdt.core.formatter.indent_body_declarations_compare_to_record_header" value="true"/>
        <setting id="org.eclipse.jdt.core.formatter.insert_space_after_comma_in_record_components" value="insert"/>
        <setting id="org.eclipse.jdt.core.formatter.insert_space_after_opening_paren_in_record_declaration" value="do not insert"/>
        <setting id="org.eclipse.jdt.core.formatter.insert_space_before_closing_paren_in_record_declaration" value="do not insert"/>
        <setting id="org.eclipse.jdt.core.formatter.insert_space_before_comma_in_record_components" value="insert"/>
        <setting id="org.eclipse.jdt.core.formatter.insert_space_before_opening_brace_in_record_constructor" value="insert"/>
        <setting id="org.eclipse.jdt.core.formatter.insert_space_before_opening_brace_in_record_declaration" value="insert"/>
        <setting id="org.eclipse.jdt.core.formatter.insert_space_before_opening_paren_in_record_declaration" value="do not insert"/>
        <setting id="org.eclipse.jdt.core.formatter.keep_record_constructor_on_one_line" value="one_line_never"/>
        <setting id="org.eclipse.jdt.core.formatter.keep_record_declaration_on_one_line" value="one_line_never"/>
        <setting id="org.eclipse.jdt.core.formatter.parentheses_positions_in_record_declaration" value="common_lines"/>
  </profile>
</profiles>

Despite those settings, the formatting with 2.25.0 is completely different than 2.24.1.

After performing a git bisect, the offending commit is df94a38 but these changes do not seem related to Java record types.

[Naros]

Any update on this?

[hazendaz]

I ran a test on record class by putting your class into the build. It formatted without any issue. Our tests run 2 times to shake out any after affects, it worked fine on both so not sure what the issue is you are having.