Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs]: <Set private> is deprecated, used within Router docs #9748

Closed
1 task done
suzdalnitski opened this issue Dec 23, 2023 · 1 comment
Closed
1 task done

[Docs]: <Set private> is deprecated, used within Router docs #9748

suzdalnitski opened this issue Dec 23, 2023 · 1 comment
Labels
topic/docs

Comments

@suzdalnitski
Copy link
Contributor

suzdalnitski commented Dec 23, 2023 •
edited
Loading

Summary and description

The docs mention:

  <Set private unauthenticated="home">
    <Route path="/admin" page={AdminPage} name="admin" />
  </Set>

However, <Set private> is deprecated. I think the docs should be updated to make use of PrivateSet instead?

https://github.com/redwoodjs/redwood/blob/main/docs/docs/router.md

Are you interested in working on this?

  • I'm interested in working on this
@suzdalnitski
Copy link
Contributor Author

I've opened a PR while I was at it, please let me know if this makes sense: #9749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic/docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@suzdalnitski