Skip to content

Commit 9c2e599

Browse files
committed
feat(test): use tracing instead of fern for agent mock
1 parent 2b951f9 commit 9c2e599

File tree

3 files changed

+14
-10
lines changed

3 files changed

+14
-10
lines changed

src/filter/filter_body.rs

+4-2
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,8 @@ impl FilterBodyAction {
5858

5959
match self.do_filter(data.clone()) {
6060
Ok(filtered) => filtered,
61-
Err(_) => {
61+
Err(err) => {
62+
log::error!("error while filtering: {}", err);
6263
self.in_error = true;
6364

6465
data
@@ -85,7 +86,8 @@ impl FilterBodyAction {
8586

8687
match self.do_end() {
8788
Ok(end) => end,
88-
Err(_) => {
89+
Err(err) => {
90+
log::error!("error while ending filtering: {}", err);
8991
self.in_error = true;
9092

9193
Vec::new()

src/filter/gzip_filter_body.rs

+2
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ impl GzDecodeFilterBody {
3232
let mut decoder = GzDecoder::new(Cursor::new(Vec::new()));
3333
std::mem::swap(&mut self.decoder, &mut decoder);
3434

35+
decoder.try_finish()?;
3536
Ok(decoder.finish()?.into_inner())
3637
}
3738
}
@@ -56,6 +57,7 @@ impl GzEncodeFilterBody {
5657
let mut encoder = GzEncoder::new(Cursor::new(Vec::new()), flate2::Compression::default());
5758
std::mem::swap(&mut self.encoder, &mut encoder);
5859

60+
encoder.try_finish()?;
5961
Ok(encoder.finish()?.into_inner())
6062
}
6163
}

src/filter/html_body_action/mod.rs

+8-8
Original file line numberDiff line numberDiff line change
@@ -70,16 +70,16 @@ impl HtmlBodyVisitor {
7070
}
7171

7272
pub fn evaluate(data: &str, expression: &str) -> bool {
73-
let document = scraper::Html::parse_fragment(data);
74-
let selector_result = scraper::Selector::parse(expression);
75-
76-
if selector_result.is_err() {
77-
error!("Cannot parse selector {}: {:?}", expression, selector_result.err().unwrap());
73+
let selector = match scraper::Selector::parse(expression) {
74+
Ok(selector) => selector,
75+
Err(err) => {
76+
log::error!("cannot parse selector {}: {:?}", expression, err);
7877

79-
return false;
80-
}
78+
return false;
79+
}
80+
};
8181

82-
let selector = selector_result.unwrap();
82+
let document = scraper::Html::parse_fragment(data);
8383
let mut select = document.select(&selector);
8484

8585
select.next().is_some()

0 commit comments

Comments
 (0)