Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: keep composer lock in git #495

Merged
merged 2 commits into from
Jul 5, 2022
Merged

fix: keep composer lock in git #495

merged 2 commits into from
Jul 5, 2022

Conversation

erunion
Copy link
Member

@erunion erunion commented Jul 5, 2022

🧰 Changes

We've been having issues with PHP builds in CI being unstable because we haven't kept composer.lock in git. This fixes that!

@erunion erunion added area:php refactor Issues about tackling technical debt labels Jul 5, 2022
@erunion erunion requested a review from domharrington July 5, 2022 17:16
@domharrington domharrington merged commit 7682467 into main Jul 5, 2022
@domharrington domharrington deleted the fix/keep-composer-lock-in-git branch July 5, 2022 17:42
@erunion erunion added php Issues related to our PHP SDK and removed area:php labels Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domharrington domharrington domharrington approved these changes

Assignees
No one assigned
Labels
php Issues related to our PHP SDK refactor Issues about tackling technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erunion @domharrington