Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
This commit adds simple request batching behavior to the middleware.
Previously, each request made to an application using this middleware
would cause a new request to be sent to the ReadMe API. A new
RequestQueue
object was introduced to collect requests and provide abatched response to send out when ready.
The batch size can be controlled by the user using the
buffer_length
option. It defaults to 10.
🧪 Testing
Both unit and integrations tests were added to cover the new functionality.
Using the following sample application and curl request, we confirmed that middleware appropriately batches the requests.
curl 'http://localhost:9292/api/foo?id=1&name=joel' -H "X-Filtered: my custom header" -H "Content-Type: application/json" -X POST -d '{"key": "value", "dont_filter": "not filtered"}'