Extract test helper factory for http requests #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelQ
force-pushed
the
jq-extract-test-helper
branch
from
7c7983b to
8bfda00
Compare
thestrabusiness
approved these changes
Aug 18, 2020
This allows us to build up full http request doubles, without having to specify values we don't care about. Note that if overriding the `url` property to add query parameters, you should also set the `query_params` property as the factory method doesn't do any logic to keep these two in sync.
JoelQ
force-pushed
the
jq-extract-test-helper
branch
from
528a392 to
f6bf57b
Compare
djmango
pushed a commit
to djmango/metrics-sdks
that referenced
this pull request
Sep 19, 2023
* Fix omit for nested objects We’re using the dedicated lodash.omit package from npm to reduce our bundle size. But it looks like the smaller npm modules are out of date: https://github.com/lodash/lodash/issues/4254 lodash/lodash#4193 lodash/lodash#4030 Can confirm this works when using the full [email protected] module, and not the [email protected] module. ``` const omit = require('lodash.omit'); omit({ a: { b: { c: 1 } } }, ['a.b.c']) { a: { b: { c: 1 } } } const omit = require('lodash/omit'); omit({ a: { b: { c: 1 } } }, ['a.b.c']) { a: { b: {} } } ``` * Remove individual lodash packages and include entire lodash library. * Add test for blacklisting/whitelisting nested properties in response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
This allows us to build up full http request doubles, without having to
specify values we don't care about.
Note that if overriding the
urlproperty to add query parameters, youshould also set the
query_paramsproperty as the factory methoddoesn't do any logic to keep these two in sync.
🧪 Testing
This whole PR is all testing 😆