Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(node): try and bring back in regular node v16 #445

Merged
merged 1 commit into from
May 2, 2022
Merged

test(node): try and bring back in regular node v16 #445

merged 1 commit into from
May 2, 2022

Conversation

domharrington
Copy link
Member

No description provided.

Dashron
Dashron approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@Dashron Dashron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, wonder why we did this. tests pass so 👍

@domharrington
Copy link
Member Author

@Dashron see the comment on the change! node shipped with a broken npm for a bit which broke our CI.

@domharrington domharrington merged commit 57ae481 into main May 2, 2022
@domharrington domharrington deleted the feature/remove-pinned-node-16 branch May 2, 2022 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erunion erunion erunion approved these changes

@Dashron Dashron Dashron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@domharrington @erunion @Dashron