Extract HttpRequest object
#44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Rack::Request` provides some niceties over a raw env hash but is still missing some key behavior such as getting HTTP headers or safely reading the body. This extracts an object to that wraps `Rack::Request` and provides a nice interface for these things. Some of the methods just delegate to existing `Rack::Request` functionality. I made the decision not to try and isolate the two in testing in order to get more readable tests.
thestrabusiness
approved these changes
Aug 17, 2020
djmango
pushed a commit
to djmango/metrics-sdks
that referenced
this pull request
Sep 19, 2023
Bumps [nock](https://github.com/nock/nock) from 12.0.1 to 12.0.2. - [Release notes](https://github.com/nock/nock/releases) - [Changelog](https://github.com/nock/nock/blob/master/CHANGELOG.md) - [Commits](nock/nock@v12.0.1...v12.0.2) Signed-off-by: dependabot-preview[bot] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
Rack::Requestprovides some niceties over a raw env hash but is stillmissing some key behavior such as getting HTTP headers or safely reading
the body.
This extracts an object to that wraps
Rack::Requestand provides anice interface for these things. Some of the methods just delegate to
existing
Rack::Requestfunctionality. I made the decision not to tryand isolate the two in testing in order to get more readable tests.
🧪 Testing
This is a pure refactor with no behavior changes. Additional automated unit tests were added around newly public behavior.