-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: python package renaming #34
Conversation
@emilyskuo Were you able to run the unit tests we've got in here at all? I can never remember the way to run them with |
@erunion the tests don't currently have any assertions in them (they're all commented out). You should be able to run them with |
haha i didn't realize there weren't any assertions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. @mjcuva you want to merge and build a new release?
I don't aestetically love the underscore in readme_metrics. Is that a common thing in python? How do most packages do it? I don't love |
@mjcuva underscores (snake case) is the typical way to do it in Python! Capitalization (upper camel case??) is typically used with class names. |
Cool, if it's standard then I'm down for it! I'll build a new release and update the pr in readme. Thank you so much @emilyskuo!! |
* chore: rename package to readme_metrics & linting * chore: fix import statements * fix: syntax error
Bumps [nock](https://github.com/nock/nock) from 11.7.1 to 11.7.2. - [Release notes](https://github.com/nock/nock/releases) - [Changelog](https://github.com/nock/nock/blob/master/CHANGELOG.md) - [Commits](nock/nock@v11.7.1...v11.7.2) Signed-off-by: dependabot-preview[bot] <[email protected]>
🧰 What's being changed?
Renaming the ReadMe Metrics Python package to readme_metrics, some linting, simplifying imports.