Move JSON generation out of the middleware #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a refactor that moves JSON generation out of the middleware and in to two new classes `Readme::Har` and `Readme::Payload`. We added a new custom matcher for the JSON schema using the [json-schema gem] based on [this blog post]. We were unable to use an [existing gem] that contained a similar RSpec matcher because it is built on top of the [json_schema gem] (note the underscore rather than dash) that seems to be having issues when expanding references to other local schema files. [this blog post]: https://github.com/thoughtbot/json_matchers [json-schema gem]: https://github.com/ruby-json-schema/json-schema [existing gem]: https://github.com/thoughtbot/json_matchers [json_schema gem]: https://github.com/brandur/json_schema
thestrabusiness
force-pushed
the
am-jq-move-json-generation
branch
from
70551b2 to
989900b
Compare
djmango
pushed a commit
to djmango/metrics-sdks
that referenced
this pull request
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
This commit is a refactor that moves JSON generation out of the
middleware and in to two new classes
Readme::HarandReadme::Payload.We added a new custom matcher for the JSON schema using the json-schema
gem based on this blog post. We were unable to use an existing gem
that contained a similar RSpec matcher because it is built on top of the
json_schema gem (note the underscore rather than dash) that seems to
be having issues when expanding references to other local schema files.
🧪 Testing
This is a pure refactor. No new features were added. No manually testing is required. We added additional automated tests around the existing behavior.