Create simple HTTP-logging middleware #28
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
This creates a simple middleware that logs requests received to the
given logging API endpoint in the format:
"GET http://example.com"
.The actual Readme.io payload format is more complicated than this. We
will add support for it in a follow-up commit.
🧪 Testing
There is an automated test using
Rspec
andRack::Test
. We also tested manually with a simple Rack application that acts as both the client API and the Readme API:Run this on the command-line with
Then try to hit one of the "client API" endpoints:
In the server logs of the rack application, you should expect to see: