feat(python): documented way to skip logging a request #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGWU82
force-pushed
the
python-metrics-client-allow-user-not-to-rm-1307
branch
from
e12cedc to
fa269dd
Compare
erunion
approved these changes
Jul 8, 2021
Co-authored-by: Jon Ursenbach <[email protected]>
Co-authored-by: Jon Ursenbach <[email protected]>
Co-authored-by: Jon Ursenbach <[email protected]>
domharrington
pushed a commit
that referenced
this pull request
Apr 19, 2022
* feat: documented way to skip logging a request * Update packages/python/README.md Co-authored-by: Jon Ursenbach <[email protected]> * Update packages/python/README.md Co-authored-by: Jon Ursenbach <[email protected]> * Update packages/python/README.md Co-authored-by: Jon Ursenbach <[email protected]> Co-authored-by: Jon Ursenbach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
Give users a clear way to mark requests that shouldn't be logged to ReadMe. A grouping function can return
Nonewhich is an indication that the log should not be captured and sent to ReadMe.Added documentation to
README.mdand added the functionality to the Metrics core processor.🧪 Testing
Added unit tests. Also tested with the metrics-test-python test server, see this commit: https://github.com/readmeio/metrics-test-python/commit/6484c2767fd524237d08352e10082a431d40de8a