Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add code scanning workflow #251

Merged
merged 3 commits into from
Jun 23, 2021
Merged

add code scanning workflow #251

merged 3 commits into from
Jun 23, 2021

Conversation

ilias-t
Copy link
Contributor

@ilias-t ilias-t commented Jun 23, 2021

🧰 What's being changed?

Thoughts on adding this workflow?

@ilias-t ilias-t requested a review from erunion June 23, 2021 00:49
@erunion
Copy link
Member

erunion commented Jun 23, 2021

Lets do it. Can you also add a config file to ignore node_modules/ and vendor dirs? When they first released it all it was scanning those so I'm not sure if they've since fixed that.

You can use these as templates:

@ilias-t
Copy link
Contributor Author

ilias-t commented Jun 23, 2021

dang that ruby test is flakey, it eventually passed after like 5x

UPDATE: failing again 😭

@ilias-t ilias-t force-pushed the add-code-scanning branch from fb87e49 to 7dcef0d Compare June 23, 2021 01:04
@ilias-t ilias-t force-pushed the add-code-scanning branch from 7dcef0d to b3ae774 Compare June 23, 2021 01:06
@erunion erunion merged commit 0e07b03 into master Jun 23, 2021
@erunion erunion deleted the add-code-scanning branch June 23, 2021 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants