Fix omit for nested objects (#46)

* Fix omit for nested objects

We’re using the dedicated lodash.omit package from npm to reduce our bundle size. But it looks like the smaller npm modules are out of date:
https://github.com/lodash/lodash/issues/4254
lodash/lodash#4193
lodash/lodash#4030

Can confirm this works when using the full [email protected]  module, and not the [email protected] module.
```
const omit = require('lodash.omit');
 omit({ a: { b: { c: 1 } } }, ['a.b.c'])
{ a: { b: { c: 1 } } }
 const omit = require('lodash/omit');
 omit({ a: { b: { c: 1 } } }, ['a.b.c'])
{ a: { b: {} } }
```

* Remove individual lodash packages and include entire lodash library.

* Add test for blacklisting/whitelisting nested properties in response

Author: darrenyong

lib/process-request.js

@@ -1,6 +1,6 @@
 const url = require('url');
-const removeProperties = require('lodash.omit');
-const removeOtherProperties = require('lodash.pick');
+const removeProperties = require('lodash/omit');
+const removeOtherProperties = require('lodash/pick');
 
 const objectToArray = require('./object-to-array');
 

lib/process-response.js

@@ -1,5 +1,5 @@
-const removeProperties = require('lodash.omit');
-const removeOtherProperties = require('lodash.pick');
+const removeProperties = require('lodash/omit');
+const removeOtherProperties = require('lodash/pick');
 
 const objectToArray = require('./object-to-array');
 

package-lock.json

@@ -8,8 +8,7 @@
   "dependencies": {
     "configly": "^4.1.0",
     "jsonwebtoken": "^8.3.0",
-    "lodash.omit": "^4.5.0",
-    "lodash.pick": "^4.4.0",
+    "lodash": "^4.17.15",
     "node-uuid": "^1.4.8",
     "r2": "^2.0.1"
   },

package.json

@@ -34,6 +34,17 @@ describe('processRequest()', () => {
         });
     });
 
+    it('should strip blacklisted nested properties', () => {
+      const app = createApp({ blacklist: ['a.b.c'] });
+
+      return request(app)
+        .post('/')
+        .send({ a: { b: { c: 1 } } })
+        .expect(({ body }) => {
+          expect(body.postData.params).toStrictEqual([{ name: 'a', value: { b: {} } }]);
+        });
+    });
+
     it('should only send whitelisted properties', () => {
       const app = createApp({ whitelist: ['password', 'apiKey'] });
 
@@ -47,6 +58,17 @@ describe('processRequest()', () => {
           ]);
         });
     });
+
+    it('should only send whitelisted nested properties', () => {
+      const app = createApp({ whitelist: ['a.b.c'] });
+
+      return request(app)
+        .post('/')
+        .send({ a: { b: { c: 1 } }, d: 2 })
+        .expect(({ body }) => {
+          expect(body.postData.params).toStrictEqual([{ name: 'a', value: { b: { c: 1 } } }]);
+        });
+    });
   });
 
   it('#method', () =>

test/process-request.test.js

@@ -33,6 +33,15 @@ describe('processResponse()', () => {
       }, JSON.stringify({ password: '123456', apiKey: 'abcdef', another: 'Hello world' }));
     });
 
+    it('should strip blacklisted nested properties', () => {
+      expect.hasAssertions();
+      return testResponse(res => {
+        expect(processResponse(res, { blacklist: ['a.b.c'] }).content.text).toStrictEqual(
+          JSON.stringify({ a: { b: {} } })
+        );
+      }, JSON.stringify({ a: { b: { c: 1 } } }));
+    });
+
     it('should only send whitelisted properties', () => {
       expect.hasAssertions();
       return testResponse(res => {
@@ -42,6 +51,15 @@ describe('processResponse()', () => {
       }, JSON.stringify({ password: '123456', apiKey: 'abcdef', another: 'Hello world' }));
     });
 
+    it('should only send whitelisted nested properties', () => {
+      expect.hasAssertions();
+      return testResponse(res => {
+        expect(processResponse(res, { whitelist: ['a.b.c'] }).content.text).toStrictEqual(
+          JSON.stringify({ a: { b: { c: 1 } } })
+        );
+      }, JSON.stringify({ a: { b: { c: 1 } }, d: 2 }));
+    });
+
     it('should not be applied for plain text bodies', () => {
       expect.hasAssertions();
       const body = 'hello world: dasdsas';