fix: don't stringify empty post bodies (#79)

* fix: don't stringify empty post bodies

* fix: add check for req.body and fix some tests

Author: kanadgupta

lib/process-request.js

@@ -16,17 +16,20 @@ module.exports = (req, options = {}) => {
     req.headers = removeOtherProperties(req.headers, options.whitelist);
   }
 
-  // parse mimetype from content-type header, default to JSON
-  const postData = { mimeType: 'application/json' };
-  try {
-    postData.mimeType = contentType.parse(req).type;
-  } catch (e) {} // eslint-disable-line no-empty
+  const postData = {};
+  if (req.body && Object.keys(req.body).length > 0) {
+    // parse mimetype from content-type header, default to JSON
+    postData.mimeType = 'application/json';
+    try {
+      postData.mimeType = contentType.parse(req).type;
+    } catch (e) {} // eslint-disable-line no-empty
 
-  // Per HAR, we send JSON as postData.text, not params.
-  if (postData.mimeType === 'application/json') {
-    postData.text = JSON.stringify(req.body);
-  } else {
-    postData.params = objectToArray(req.body || {});
+    // Per HAR, we send JSON as postData.text, not params.
+    if (postData.mimeType === 'application/json') {
+      postData.text = JSON.stringify(req.body);
+    } else {
+      postData.params = objectToArray(req.body || {});
+    }
   }
 
   return {

package-lock.json

@@ -30,7 +30,7 @@ describe('constructPayload()', () => {
       .expect(({ body }) => {
         expect(typeof body.request.log.entries[0].request).toBe('object');
         expect(typeof body.request.log.entries[0].response).toBe('object');
-        expect(body.request.log.entries[0].request.postData.text).toBe('{}');
+        expect(body.request.log.entries[0].request.postData).toStrictEqual({});
       });
   }, 8000);
 

test/construct-payload.test.js

@@ -15,6 +15,8 @@ function createApp(options) {
 
   app.use('/test-base-path', router);
 
+  app.get('/*', (req, res) => res.json(processRequest(req, options)));
+
   app.post('/*', (req, res) => {
     res.json(processRequest(req, options));
   });
@@ -257,8 +259,19 @@ describe('processRequest()', () => {
     it('#mimeType should default to application/json', () =>
       request(createApp())
         .post('/')
+        .send({ a: 1 })
         .expect(({ body }) => expect(body.postData.mimeType).toBe('application/json')));
 
+    it('should be an empty object if request is a GET', () =>
+      request(createApp())
+        .get('/')
+        .expect(({ body }) => expect(body.postData).toStrictEqual({})));
+
+    it('should be an empty object if req.body is empty', () =>
+      request(createApp())
+        .post('/')
+        .expect(({ body }) => expect(body.postData).toStrictEqual({})));
+
     it('#text should contain stringified body', () => {
       const body = { a: 1, b: 2 };
       return request(createApp())