Skip to content

Commit 6d45dfd

Browse files
committed
RFC: remove React Transform from examples
1 parent 3dfdd0a commit 6d45dfd

File tree

4 files changed

+38
-16
lines changed

4 files changed

+38
-16
lines changed

examples/async/.babelrc

+1-6
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,3 @@
11
{
2-
"presets": ["es2015", "react"],
3-
"env": {
4-
"development": {
5-
"presets": ["react-hmre"]
6-
}
7-
}
2+
"presets": ["es2015", "react"]
83
}

examples/async/index.js

+36-8
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,43 @@
11
import 'babel-polyfill'
22
import React from 'react'
3-
import { render } from 'react-dom'
3+
import ReactDOM from 'react-dom'
44
import { Provider } from 'react-redux'
5-
import App from './containers/App'
65
import configureStore from './store/configureStore'
76

87
const store = configureStore()
8+
const rootEl = document.getElementById('root')
99

10-
render(
11-
<Provider store={store}>
12-
<App />
13-
</Provider>,
14-
document.getElementById('root')
15-
)
10+
let render = () => {
11+
const App = require('./containers/App').default
12+
ReactDOM.render(
13+
<Provider store={store}>
14+
<App />
15+
</Provider>,
16+
rootEl
17+
)
18+
}
19+
20+
if (module.hot) {
21+
// Support hot reloading of components
22+
// and display an overlay for runtime errors
23+
const renderApp = render
24+
const renderError = (error) => {
25+
const RedBox = require('redbox-react')
26+
ReactDOM.render(
27+
<RedBox error={error} />,
28+
rootEl
29+
)
30+
}
31+
render = () => {
32+
try {
33+
renderApp()
34+
} catch (error) {
35+
renderError(error)
36+
}
37+
}
38+
module.hot.accept('./containers/App', () => {
39+
setTimeout(render)
40+
})
41+
}
42+
43+
render()

examples/async/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,10 @@
4040
"babel-loader": "^6.2.0",
4141
"babel-preset-es2015": "^6.3.13",
4242
"babel-preset-react": "^6.3.13",
43-
"babel-preset-react-hmre": "^1.0.1",
4443
"expect": "^1.6.0",
4544
"express": "^4.13.3",
4645
"node-libs-browser": "^0.5.2",
46+
"redbox-react": "^1.2.2",
4747
"webpack": "^1.9.11",
4848
"webpack-dev-middleware": "^1.2.0",
4949
"webpack-hot-middleware": "^2.2.0"

examples/async/webpack.config.js

-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ module.exports = {
1515
plugins: [
1616
new webpack.optimize.OccurenceOrderPlugin(),
1717
new webpack.HotModuleReplacementPlugin(),
18-
new webpack.NoErrorsPlugin()
1918
],
2019
module: {
2120
loaders: [

0 commit comments

Comments
 (0)