Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] rancher-logging - Ability to add PriorityClassName to DaemonSet/Logging/FluentBitAgent CRDs #49048

Open
jmeza-xyz opened this issue Feb 7, 2025 · 2 comments
Labels
kind/enhancement Issues that improve or augment existing functionality
Milestone

Comments

@jmeza-xyz
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Rancher-Logging helm chart currently has a global priorityClassName in the values.yaml but this not propagate to all resources deployed by the chart.

SURE-9662

Describe the solution you'd like
DaemonSet/Logging/FluentBitAgent CRDs have the option to set priorityClassName and podPriorityClassName respectively per their specs. Correctly propagate it or add options to pass it to all resources.

Describe alternatives you've considered

  • Manually patching each resource with priorityClassNameor podPriorityClassName
  • Using a policy with Kyverno to patch these resources - (should not be used for this purpose)

Additional context

priorityClassName: system-critical  <---- # this works for the rancher-logging Deployment. No other resources
fluentbit:
  priorityClassName: system-cluster-critical <---------------------- # This does nothing
    resources:
      limits:
        cpu: 1
        memory: 3Gi
      requests:
        cpu: 500m
          memory: 3Gi
fluentd:
  priorityClassName: system-cluster-critical <---------------------- # This does nothing
  replicas: 2

Example of DaemonSet template not having this option. https://github.com/rancher/charts/blob/dev-v2.10/charts/rancher-logging/105.2.0%2Bup4.10.0/templates/loggings/rke2/daemonset.yaml#L20-L61

@mallardduck
Copy link
Member

mallardduck commented Mar 7, 2025

PR here: rancher/charts#5212 (note this was already incorporated into a release on ob-team-charts, so this is the rancher/charts release of that change)

@mallardduck
Copy link
Member

Just a heads up @jmeza-xyz - as this will target 2.11.1 it cannot merge until after 2.11.0 release is fully complete. Aim to follow up on this after March 26th (tentative 2.11.0 release day)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Issues that improve or augment existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants