Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example 03xComposedPulses not reproducible #707

Closed
Nomos11 opened this issue Dec 1, 2022 · 2 comments · Fixed by #708
Closed

Example 03xComposedPulses not reproducible #707

Nomos11 opened this issue Dec 1, 2022 · 2 comments · Fixed by #708

Comments

@Nomos11
Copy link
Collaborator

Nomos11 commented Dec 1, 2022

Plot of second_point_pt of PointPT does not reproduce same behavior (linear voltage decline) as saved in ipynb-file, instead shows constant value. In particular,

from qupulse.pulses import PointPT
from qupulse.pulses.plotting import plot
second_point_pt = PointPT([(0, 'v_0+v_1'),
                           ('t_2', 'v_0', 'linear')],
                          channel_names={'A'},
                          measurements={('M', 0, 1)})
parameters = dict(t=3,
                  t_2=2,
                  v_0=1,
                  v_1=1.4)
_ = plot(second_point_pt, parameters, sample_rate=100)

outputs plot of constant voltage. (Adding third datapoint restores expected behavior)

@shumpohl
Copy link
Member

shumpohl commented Dec 1, 2022

Thanks for the report! Looks like a regression somewhen after 0.6. second_point_pt is wrongly translated into a ConstantWaveform. The error is in TableWaveform._validate_input.

@shumpohl
Copy link
Member

shumpohl commented Dec 1, 2022

Error was introduced in 8345423

I guess this requires a 0.7.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants