Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graphql-ws v6 to peer deps #173

Closed
yusufkandemir opened this issue Mar 10, 2025 · 2 comments
Closed

Add graphql-ws v6 to peer deps #173

yusufkandemir opened this issue Mar 10, 2025 · 2 comments
Assignees

Comments

@yusufkandemir
Copy link
Member

The breaking changes made in v6 are only related to server usage:
https://github.com/enisdenjo/graphql-ws/releases/tag/v6.0.0
So, the client usage in this AE is not affected and will still work as before.

This range can be updated to include ^6.0.0:

"graphql-ws": "^5.14.0",

@smolinari smolinari self-assigned this Mar 10, 2025
@smolinari
Copy link
Collaborator

smolinari commented Mar 11, 2025

Fixed via #175

Scott

@yusufkandemir
Copy link
Member Author

Thanks, but I said it can be included, but it should not be the only thing. "graphql-ws": "^5.14.0 || ^6.0.0", should allow both 5 and 6. The existing users will start getting warnings/errors now and forced to upgrade to v6. The upgrade is nothing special, but it's still not great IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants