Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension v2 doesn't install due to @quasar/app dependency missing in quasar vite setup #119

Closed
michal-myszka-cognitran opened this issue Jun 7, 2022 · 1 comment

Comments

@michal-myszka-cognitran
Copy link

michal-myszka-cognitran commented Jun 7, 2022

The extension is checking for @quasar/app:
api.compatibleWith('@quasar/app', '>=3.0.0-beta.8 <4.0.0')

This condition needs to be changed to accommodate for @quasar/app-vite.

module.exports = function (api) {
  // Quasar compatibility check.
  api.compatibleWith('quasar', '>=2.0.0-beta.8 <3.0.0')
  if (api.hasVite === true) {
    api.compatibleWith('@quasar/app-vite', '^1.0.0')
  }
  else {
    api.compatibleWith('@quasar/app', '>=3.0.0-beta.8 <4.0.0')
  }

  // Render templates in the app.
  if (api.prompts.typescript) {
    api.render('./templates')
  } else {
    api.render('../lib/templates')
  }

  api.extendJsonFile('.vscode/extensions.json', {
    recommendations: ['apollographql.vscode-apollo'],
  })
}
@smolinari
Copy link
Collaborator

This should be fixed in beta 4.

Scott

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants