From 25e0fe3dc6267dfca662fa1b6a2848cf0bc39bc5 Mon Sep 17 00:00:00 2001 From: sobolevn Date: Wed, 15 Sep 2021 23:33:23 +0300 Subject: [PATCH 1/4] bpo-45209: removes `UserWarning: resource_tracker` in `test_multiprocessing` --- Lib/test/_test_multiprocessing.py | 7 +++++++ .../next/Tests/2021-09-15-23-32-39.bpo-45209.55ntL5.rst | 2 ++ 2 files changed, 9 insertions(+) create mode 100644 Misc/NEWS.d/next/Tests/2021-09-15-23-32-39.bpo-45209.55ntL5.rst diff --git a/Lib/test/_test_multiprocessing.py b/Lib/test/_test_multiprocessing.py index 8ebcd0d64dfaa9..1e893e6bc2c66f 100644 --- a/Lib/test/_test_multiprocessing.py +++ b/Lib/test/_test_multiprocessing.py @@ -4177,6 +4177,13 @@ def test_shared_memory_cleaned_after_process_termination(self): raise AssertionError("A SharedMemory segment was leaked after" " a process was abruptly terminated.") + # Without this line it was raising warnings like: + # UserWarning: resource_tracker: + # There appear to be 1 leaked shared_memory + # objects to clean up at shutdown + # See: https://bugs.python.org/issue45209 + resource_tracker.unregister(f"/{name}", "shared_memory") + if os.name == 'posix': # A warning was emitted by the subprocess' own # resource_tracker (on Windows, shared memory segments diff --git a/Misc/NEWS.d/next/Tests/2021-09-15-23-32-39.bpo-45209.55ntL5.rst b/Misc/NEWS.d/next/Tests/2021-09-15-23-32-39.bpo-45209.55ntL5.rst new file mode 100644 index 00000000000000..b7fa5b3c875219 --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2021-09-15-23-32-39.bpo-45209.55ntL5.rst @@ -0,0 +1,2 @@ +Fixes ``UserWarning: resource_tracker`` warning in +``test_shared_memory_cleaned_after_process_termination`` From 95b5858fd4d50222db40b7bd989fc7826c06b795 Mon Sep 17 00:00:00 2001 From: sobolevn Date: Thu, 16 Sep 2021 00:03:02 +0300 Subject: [PATCH 2/4] Fixes windows tests --- Lib/test/_test_multiprocessing.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/Lib/test/_test_multiprocessing.py b/Lib/test/_test_multiprocessing.py index 1e893e6bc2c66f..125e8906d8abce 100644 --- a/Lib/test/_test_multiprocessing.py +++ b/Lib/test/_test_multiprocessing.py @@ -4177,14 +4177,14 @@ def test_shared_memory_cleaned_after_process_termination(self): raise AssertionError("A SharedMemory segment was leaked after" " a process was abruptly terminated.") - # Without this line it was raising warnings like: - # UserWarning: resource_tracker: - # There appear to be 1 leaked shared_memory - # objects to clean up at shutdown - # See: https://bugs.python.org/issue45209 - resource_tracker.unregister(f"/{name}", "shared_memory") - if os.name == 'posix': + # Without this line it was raising warnings like: + # UserWarning: resource_tracker: + # There appear to be 1 leaked shared_memory + # objects to clean up at shutdown + # See: https://bugs.python.org/issue45209 + resource_tracker.unregister(f"/{name}", "shared_memory") + # A warning was emitted by the subprocess' own # resource_tracker (on Windows, shared memory segments # are released automatically by the OS). From 540d1f48a41a35a2c1315c57b7f4627622c3aeb1 Mon Sep 17 00:00:00 2001 From: Nikita Sobolev Date: Thu, 16 Sep 2021 22:55:07 +0300 Subject: [PATCH 3/4] Update 2021-09-15-23-32-39.bpo-45209.55ntL5.rst --- Misc/NEWS.d/next/Tests/2021-09-15-23-32-39.bpo-45209.55ntL5.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Misc/NEWS.d/next/Tests/2021-09-15-23-32-39.bpo-45209.55ntL5.rst b/Misc/NEWS.d/next/Tests/2021-09-15-23-32-39.bpo-45209.55ntL5.rst index b7fa5b3c875219..f14a416e3d6bb3 100644 --- a/Misc/NEWS.d/next/Tests/2021-09-15-23-32-39.bpo-45209.55ntL5.rst +++ b/Misc/NEWS.d/next/Tests/2021-09-15-23-32-39.bpo-45209.55ntL5.rst @@ -1,2 +1,2 @@ -Fixes ``UserWarning: resource_tracker`` warning in +Fix ``UserWarning: resource_tracker`` warning in ``test_shared_memory_cleaned_after_process_termination`` From 772ffd7a0edd38a7def183000dabbeefbb0c3fe8 Mon Sep 17 00:00:00 2001 From: Nikita Sobolev Date: Mon, 20 Sep 2021 13:40:46 +0300 Subject: [PATCH 4/4] Mentions `_test_multiprocessing` in NEWS --- Misc/NEWS.d/next/Tests/2021-09-15-23-32-39.bpo-45209.55ntL5.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Misc/NEWS.d/next/Tests/2021-09-15-23-32-39.bpo-45209.55ntL5.rst b/Misc/NEWS.d/next/Tests/2021-09-15-23-32-39.bpo-45209.55ntL5.rst index f14a416e3d6bb3..4c3bed0983b899 100644 --- a/Misc/NEWS.d/next/Tests/2021-09-15-23-32-39.bpo-45209.55ntL5.rst +++ b/Misc/NEWS.d/next/Tests/2021-09-15-23-32-39.bpo-45209.55ntL5.rst @@ -1,2 +1,2 @@ Fix ``UserWarning: resource_tracker`` warning in -``test_shared_memory_cleaned_after_process_termination`` +``_test_multiprocessing._TestSharedMemory.test_shared_memory_cleaned_after_process_termination``