From 57736b64066dc556ab114b379add688f7f6fe3f9 Mon Sep 17 00:00:00 2001 From: Terry Jan Reedy Date: Fri, 31 May 2019 02:11:37 -0400 Subject: [PATCH 1/2] IDLE - Capitalize search dialogs' 'Close' button label. It seems to be the only widget label not capitalized. --- Lib/idlelib/searchbase.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lib/idlelib/searchbase.py b/Lib/idlelib/searchbase.py index f0e3d6f14ba49b..74ba8538512b9d 100644 --- a/Lib/idlelib/searchbase.py +++ b/Lib/idlelib/searchbase.py @@ -172,7 +172,7 @@ def create_command_buttons(self): f = self.buttonframe = Frame(self.top) f.grid(row=0,column=2,padx=2,pady=2,ipadx=2,ipady=2) - b = self.make_button("close", self.close) + b = self.make_button("Close", self.close) b.lower() From 26ebabc2101928fbf30aa232e299ae2a969c7c1b Mon Sep 17 00:00:00 2001 From: Terry Jan Reedy Date: Fri, 31 May 2019 02:50:54 -0400 Subject: [PATCH 2/2] Fix test --- Lib/idlelib/idle_test/test_searchbase.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Lib/idlelib/idle_test/test_searchbase.py b/Lib/idlelib/idle_test/test_searchbase.py index 09a7fff51de1dc..6dd4d79337371d 100644 --- a/Lib/idlelib/idle_test/test_searchbase.py +++ b/Lib/idlelib/idle_test/test_searchbase.py @@ -32,6 +32,7 @@ def setUpClass(cls): @classmethod def tearDownClass(cls): + cls.root.update_idletasks() cls.root.destroy() del cls.root @@ -149,7 +150,7 @@ def test_create_command_buttons(self): # Look for close button command in buttonframe closebuttoncommand = '' for child in self.dialog.buttonframe.winfo_children(): - if child['text'] == 'close': + if child['text'] == 'Close': closebuttoncommand = child['command'] self.assertIn('close', closebuttoncommand)